From bd6a86471b52a4c4fb5d9318257b6e28401a9377 Mon Sep 17 00:00:00 2001 From: TommyStarK Date: Thu, 15 Dec 2022 13:15:03 +0100 Subject: [PATCH] kubeapiserver/admission: Improving test coverage Signed-off-by: TommyStarK --- .../admission/initializer_test.go | 79 +++++++++++++++++++ 1 file changed, 79 insertions(+) diff --git a/pkg/kubeapiserver/admission/initializer_test.go b/pkg/kubeapiserver/admission/initializer_test.go index 8a37bcbe469..a9fdd5fcece 100644 --- a/pkg/kubeapiserver/admission/initializer_test.go +++ b/pkg/kubeapiserver/admission/initializer_test.go @@ -20,7 +20,10 @@ import ( "context" "testing" + "k8s.io/apimachinery/pkg/api/meta" + "k8s.io/apimachinery/pkg/runtime/schema" "k8s.io/apiserver/pkg/admission" + quota "k8s.io/apiserver/pkg/quota/v1" ) type doNothingAdmission struct{} @@ -31,6 +34,10 @@ func (doNothingAdmission) Admit(ctx context.Context, a admission.Attributes, o a func (doNothingAdmission) Handles(o admission.Operation) bool { return false } func (doNothingAdmission) Validate() error { return nil } +type doNothingPluginInitialization struct{} + +func (doNothingPluginInitialization) ValidateInitialization() error { return nil } + type WantsCloudConfigAdmissionPlugin struct { doNothingAdmission cloudConfig []byte @@ -50,3 +57,75 @@ func TestCloudConfigAdmissionPlugin(t *testing.T) { t.Errorf("Expected cloud config to be initialized but found nil") } } + +type doNothingRESTMapper struct{} + +func (doNothingRESTMapper) KindFor(resource schema.GroupVersionResource) (schema.GroupVersionKind, error) { + return schema.GroupVersionKind{}, nil +} +func (doNothingRESTMapper) KindsFor(resource schema.GroupVersionResource) ([]schema.GroupVersionKind, error) { + return nil, nil +} +func (doNothingRESTMapper) ResourceFor(input schema.GroupVersionResource) (schema.GroupVersionResource, error) { + return schema.GroupVersionResource{}, nil +} +func (doNothingRESTMapper) ResourcesFor(input schema.GroupVersionResource) ([]schema.GroupVersionResource, error) { + return nil, nil +} +func (doNothingRESTMapper) RESTMapping(gk schema.GroupKind, versions ...string) (*meta.RESTMapping, error) { + return nil, nil +} +func (doNothingRESTMapper) RESTMappings(gk schema.GroupKind, versions ...string) ([]*meta.RESTMapping, error) { + return nil, nil +} +func (doNothingRESTMapper) ResourceSingularizer(resource string) (singular string, err error) { + return "", nil +} + +type WantsRESTMapperAdmissionPlugin struct { + doNothingAdmission + doNothingPluginInitialization + mapper meta.RESTMapper +} + +func (p *WantsRESTMapperAdmissionPlugin) SetRESTMapper(mapper meta.RESTMapper) { + p.mapper = mapper +} + +func TestRESTMapperAdmissionPlugin(t *testing.T) { + mapper := doNothingRESTMapper{} + initializer := NewPluginInitializer(nil, mapper, nil) + wantsRESTMapperAdmission := &WantsRESTMapperAdmissionPlugin{} + initializer.Initialize(wantsRESTMapperAdmission) + + if wantsRESTMapperAdmission.mapper == nil { + t.Errorf("Expected REST mapper to be initialized but found nil") + } +} + +type doNothingQuotaConfiguration struct{} + +func (doNothingQuotaConfiguration) IgnoredResources() map[schema.GroupResource]struct{} { return nil } + +func (doNothingQuotaConfiguration) Evaluators() []quota.Evaluator { return nil } + +type WantsQuotaConfigurationAdmissionPlugin struct { + doNothingAdmission + doNothingPluginInitialization + config quota.Configuration +} + +func (p *WantsQuotaConfigurationAdmissionPlugin) SetQuotaConfiguration(config quota.Configuration) { + p.config = config +} + +func TestQuotaConfigurationAdmissionPlugin(t *testing.T) { + config := doNothingQuotaConfiguration{} + initializer := NewPluginInitializer(nil, nil, config) + wantsQuotaConfigurationAdmission := &WantsQuotaConfigurationAdmissionPlugin{} + initializer.Initialize(wantsQuotaConfigurationAdmission) + + if wantsQuotaConfigurationAdmission.config == nil { + t.Errorf("Expected quota configuration to be initialized but found nil") + } +}