From 7a3d73d234debf347894da1ac94c8c2c8af6244f Mon Sep 17 00:00:00 2001 From: Michal Wozniak Date: Fri, 14 Jun 2024 19:59:20 +0200 Subject: [PATCH] Remove redundant check in Job success policy code --- pkg/controller/job/job_controller.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pkg/controller/job/job_controller.go b/pkg/controller/job/job_controller.go index d236b11181c..38e38b8fac7 100644 --- a/pkg/controller/job/job_controller.go +++ b/pkg/controller/job/job_controller.go @@ -880,7 +880,7 @@ func (jm *Controller) syncJob(ctx context.Context, key string) (rErr error) { } jobCtx.podsWithDelayedDeletionPerIndex = getPodsWithDelayedDeletionPerIndex(logger, jobCtx) } - if jobCtx.finishedCondition == nil && hasSuccessCriteriaMetCondition(jobCtx.job) == nil { + if jobCtx.finishedCondition == nil { if msg, met := matchSuccessPolicy(logger, job.Spec.SuccessPolicy, *job.Spec.Completions, jobCtx.succeededIndexes); met { jobCtx.finishedCondition = newCondition(batch.JobSuccessCriteriaMet, v1.ConditionTrue, batch.JobReasonSuccessPolicy, msg, jm.clock.Now()) }