From bd9e09ba004649ef1c8eea455015e51a4fb41481 Mon Sep 17 00:00:00 2001 From: Max Forbes Date: Thu, 23 Jul 2015 19:00:27 -0700 Subject: [PATCH] Implement 'Nodes Network' test for GKE --- cluster/gke/util.sh | 5 ++--- hack/ginkgo-e2e.sh | 2 +- test/e2e/resize_nodes.go | 18 ++---------------- 3 files changed, 5 insertions(+), 20 deletions(-) diff --git a/cluster/gke/util.sh b/cluster/gke/util.sh index bf8def55c92..ee55a9dd2ad 100755 --- a/cluster/gke/util.sh +++ b/cluster/gke/util.sh @@ -209,18 +209,17 @@ function get-password() { | grep password | cut -f 4 -d ' ') } -# Detect the instance name and IP for the master +# Detect the IP for the master. Note that on GKE, we don't know the name of the +# master, so KUBE_MASTER is not set. # # Assumed vars: # ZONE # CLUSTER_NAME # Vars set: -# KUBE_MASTER # KUBE_MASTER_IP function detect-master() { echo "... in detect-master()" >&2 detect-project >&2 - KUBE_MASTER="k8s-${CLUSTER_NAME}-master" KUBE_MASTER_IP=$("${GCLOUD}" "${CMD_GROUP}" container clusters describe \ --project="${PROJECT}" --zone="${ZONE}" "${CLUSTER_NAME}" \ | grep endpoint | cut -f 2 -d ' ') diff --git a/hack/ginkgo-e2e.sh b/hack/ginkgo-e2e.sh index d7e1b608f86..ce349e4b751 100755 --- a/hack/ginkgo-e2e.sh +++ b/hack/ginkgo-e2e.sh @@ -89,7 +89,7 @@ fi export PATH=$(dirname "${e2e_test}"):"${PATH}" "${ginkgo}" "${ginkgo_args[@]:+${ginkgo_args[@]}}" "${e2e_test}" -- \ "${auth_config[@]:+${auth_config[@]}}" \ - --host="https://${KUBE_MASTER_IP-}" \ + --host="https://${KUBE_MASTER_IP:-}" \ --provider="${KUBERNETES_PROVIDER}" \ --gce-project="${PROJECT:-}" \ --gce-zone="${ZONE:-}" \ diff --git a/test/e2e/resize_nodes.go b/test/e2e/resize_nodes.go index f3488187cdf..2048d7f948f 100644 --- a/test/e2e/resize_nodes.go +++ b/test/e2e/resize_nodes.go @@ -329,22 +329,8 @@ func performTemporaryNetworkFailure(c *client.Client, ns, rcName string, replica Failf("Couldn't get the external IP of host %s with addresses %v", node.Name, node.Status.Addresses) } By(fmt.Sprintf("block network traffic from node %s to the master", node.Name)) - - // TODO marekbiskup 2015-06-19 #10085 - // The use of MasterName will cause iptables to do a DNS lookup to - // resolve the name to an IP address, which will slow down the test - // and cause it to fail if DNS is absent or broken. - // Use the IP address instead. - - destination := testContext.CloudConfig.MasterName - if providerIs("aws") { - // This is the (internal) IP address used on AWS for the master - // TODO: Use IP address for all clouds? - // TODO: Avoid hard-coding this - destination = "172.20.0.9" - } - - iptablesRule := fmt.Sprintf("OUTPUT --destination %s --jump DROP", destination) + iptablesRule := fmt.Sprintf("OUTPUT --destination %s --jump DROP", + strings.TrimPrefix(testContext.Host, "https://")) defer func() { // This code will execute even if setting the iptables rule failed. // It is on purpose because we may have an error even if the new rule