From ecb38137269cfc6fecb46434d8d8f1abad0e08e4 Mon Sep 17 00:00:00 2001 From: Michael Taufen Date: Thu, 22 Jul 2021 09:35:04 -0700 Subject: [PATCH] Update component-base OWNERS to include SIG-Architecture Also update OWNERS in subdirs based on best-guess picks of appropriate OWNERS. We can update as necessary in future iterations but this'll help reduce initial noise for SIG-Arch. --- staging/src/k8s.io/component-base/OWNERS | 23 ++++++++++--------- staging/src/k8s.io/component-base/cli/OWNERS | 12 ++++++++++ .../src/k8s.io/component-base/codec/OWNERS | 11 +++++++++ .../src/k8s.io/component-base/config/OWNERS | 3 +++ .../src/k8s.io/component-base/configz/OWNERS | 17 ++++++++++++++ .../k8s.io/component-base/featuregate/OWNERS | 17 ++++++++++++++ staging/src/k8s.io/component-base/term/OWNERS | 12 ++++++++++ .../src/k8s.io/component-base/version/OWNERS | 17 ++++++++++++++ 8 files changed, 101 insertions(+), 11 deletions(-) create mode 100644 staging/src/k8s.io/component-base/cli/OWNERS create mode 100644 staging/src/k8s.io/component-base/codec/OWNERS create mode 100644 staging/src/k8s.io/component-base/configz/OWNERS create mode 100644 staging/src/k8s.io/component-base/featuregate/OWNERS create mode 100644 staging/src/k8s.io/component-base/term/OWNERS create mode 100644 staging/src/k8s.io/component-base/version/OWNERS diff --git a/staging/src/k8s.io/component-base/OWNERS b/staging/src/k8s.io/component-base/OWNERS index 89769baa499..8df88049288 100644 --- a/staging/src/k8s.io/component-base/OWNERS +++ b/staging/src/k8s.io/component-base/OWNERS @@ -1,20 +1,21 @@ # See the OWNERS docs at https://go.k8s.io/owners approvers: -- mtaufen -- stealthybox -- luxas -- sttts -- lavalamp +- sig-architecture-approvers reviewers: -- luxas -- sttts -- stewart-yu -- dims -- dixudx -- rosti +- sig-architecture-approvers emeritus_approvers: - jbeda +- lavalamp +- luxas +- mtaufen +- stealthybox +- sttts +emeritus_reviewers: +- dixudx +- rosti +- stewart-yu labels: +- sig/architecture - sig/cluster-lifecycle - sig/api-machinery diff --git a/staging/src/k8s.io/component-base/cli/OWNERS b/staging/src/k8s.io/component-base/cli/OWNERS new file mode 100644 index 00000000000..22bdeb45f90 --- /dev/null +++ b/staging/src/k8s.io/component-base/cli/OWNERS @@ -0,0 +1,12 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +# Currently assigned cli to sig-cli since: +# (a) its literally named "cli" +# (b) flags are the bread-and-butter of cli tools. + +approvers: +- sig-cli-maintainers +reviewers: +- sig-cli +labels: +- sig/cli diff --git a/staging/src/k8s.io/component-base/codec/OWNERS b/staging/src/k8s.io/component-base/codec/OWNERS new file mode 100644 index 00000000000..b2a35362554 --- /dev/null +++ b/staging/src/k8s.io/component-base/codec/OWNERS @@ -0,0 +1,11 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +# Currently assigned codec to sig-api-machinery since its used for encoding/ +# decoding KRM style manifests. + +approvers: +- sig-api-machinery-api-approvers +reviewers: +- sig-api-machinery-api-reviewers +labels: +- sig/api-machinery diff --git a/staging/src/k8s.io/component-base/config/OWNERS b/staging/src/k8s.io/component-base/config/OWNERS index 11d499d75d9..8d65ac8f204 100644 --- a/staging/src/k8s.io/component-base/config/OWNERS +++ b/staging/src/k8s.io/component-base/config/OWNERS @@ -7,8 +7,11 @@ approvers: - api-approvers reviewers: - api-reviewers +emeritus_reviewers: - luxas - mtaufen - sttts labels: - kind/api-change +- sig/api-machinery +- sig/scheduling diff --git a/staging/src/k8s.io/component-base/configz/OWNERS b/staging/src/k8s.io/component-base/configz/OWNERS new file mode 100644 index 00000000000..46bfc4718ec --- /dev/null +++ b/staging/src/k8s.io/component-base/configz/OWNERS @@ -0,0 +1,17 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +# For lack of a better idea, assigned configz to api-approvers because +# configz is an API that has been around for a long time, even if we don't +# guarantee its stability. + +# Disable inheritance as this is an api owners file +options: + no_parent_owners: true +approvers: +- api-approvers +reviewers: +- api-reviewers + +labels: +- kind/api-change +- sig/cluster-lifecycle diff --git a/staging/src/k8s.io/component-base/featuregate/OWNERS b/staging/src/k8s.io/component-base/featuregate/OWNERS new file mode 100644 index 00000000000..48e811bf4c8 --- /dev/null +++ b/staging/src/k8s.io/component-base/featuregate/OWNERS @@ -0,0 +1,17 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +# Currently assigned to api-approvers since feature gates are the API +# for enabling/disabling other APIs. + +# Disable inheritance as this is an api owners file +options: + no_parent_owners: true +approvers: +- api-approvers +reviewers: +- api-reviewers + +labels: +- kind/api-change +- sig/api-machinery +- sig/cluster-lifecycle diff --git a/staging/src/k8s.io/component-base/term/OWNERS b/staging/src/k8s.io/component-base/term/OWNERS new file mode 100644 index 00000000000..bf56e76a462 --- /dev/null +++ b/staging/src/k8s.io/component-base/term/OWNERS @@ -0,0 +1,12 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +# Currently assigned this directory to sig-cli since the main use of +# term seems to be for getting terminal size when printing help text. + +approvers: +- sig-cli-maintainers +reviewers: +- sig-cli + +labels: +- sig/cli diff --git a/staging/src/k8s.io/component-base/version/OWNERS b/staging/src/k8s.io/component-base/version/OWNERS new file mode 100644 index 00000000000..e5ca8dffb5b --- /dev/null +++ b/staging/src/k8s.io/component-base/version/OWNERS @@ -0,0 +1,17 @@ +# See the OWNERS docs at https://go.k8s.io/owners + +# Currently assigned this directory to sig-api-machinery since this is +# an interface to the version definition in "k8s.io/apimachinery/pkg/version", +# and also to sig-release since this version information is set up for +# each release. + +approvers: +- sig-api-machinery-api-approvers +- release-engineering-approvers +reviewers: +- sig-api-machinery-api-reviewers +- release-engineering-reviewers + +labels: +- sig/api-machinery +- sig/release