github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2026-01-05 07:27:21 +00:00
Code Issues Projects Releases Wiki Activity

Clear EndpointsLastChangeTriggerTime on no-change.

Browse Source 
We should clean the EndpointsLastChangeTriggerTime annotation when there
is no new trigger time to be exported. Not clearing it may result in
kube-proxy exporting the wrong Network Programming Latency SLI.
This commit is contained in:
Matt Matejczyk
2019-02-20 11:48:24 +01:00
parent d61e878533
commit bf25f7160b
2 changed files with 48 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
pkg/controller/endpoint/endpoints_controller.go
View File

@@ -522,6 +522,8 @@ func (e *EndpointController) syncService(key string) error {
if !endpointsLastChangeTriggerTime.IsZero() {
newEndpoints.Annotations[v1.EndpointsLastChangeTriggerTime] =
endpointsLastChangeTriggerTime.Format(time.RFC3339Nano)
} else { // No new trigger time, clear the annotation.
delete(newEndpoints.Annotations, v1.EndpointsLastChangeTriggerTime)
}
klog.V(4).Infof("Update endpoints for %v/%v, ready: %d not ready: %d", service.Namespace, service.Name, totalReadyEps, totalNotReadyEps)