Merge pull request #96680 from DataDog/hemanth.malla/nlc_event_type

Using UpperCamelCase event reason - DeletingNode, instead of verbose msg
This commit is contained in:
Kubernetes Prow Robot 2020-12-08 18:35:40 -08:00 committed by GitHub
commit bf713ec936
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

View File

@ -19,7 +19,6 @@ package cloud
import ( import (
"context" "context"
"errors" "errors"
"fmt"
"time" "time"
"k8s.io/api/core/v1" "k8s.io/api/core/v1"
@ -162,9 +161,8 @@ func (c *CloudNodeLifecycleController) MonitorNodes() {
Namespace: "", Namespace: "",
} }
c.recorder.Eventf(ref, v1.EventTypeNormal, c.recorder.Eventf(ref, v1.EventTypeNormal, deleteNodeEvent,
fmt.Sprintf("Deleting node %v because it does not exist in the cloud provider", node.Name), "Deleting node %s because it does not exist in the cloud provider", node.Name)
"Node %s event: %s", node.Name, deleteNodeEvent)
if err := c.kubeClient.CoreV1().Nodes().Delete(context.TODO(), node.Name, metav1.DeleteOptions{}); err != nil { if err := c.kubeClient.CoreV1().Nodes().Delete(context.TODO(), node.Name, metav1.DeleteOptions{}); err != nil {
klog.Errorf("unable to delete node %q: %v", node.Name, err) klog.Errorf("unable to delete node %q: %v", node.Name, err)