From bfc2562d6c5d36019037f86c3ec26a63325b1a7a Mon Sep 17 00:00:00 2001 From: Gyuho Lee Date: Mon, 8 Jan 2024 20:54:05 +0800 Subject: [PATCH] chores(controller/nodelifecycle): make node taint removal logs more accurate Signed-off-by: Gyuho Lee --- pkg/controller/nodelifecycle/node_lifecycle_controller.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/pkg/controller/nodelifecycle/node_lifecycle_controller.go b/pkg/controller/nodelifecycle/node_lifecycle_controller.go index f2cb62444a4..78c7f0b6c32 100644 --- a/pkg/controller/nodelifecycle/node_lifecycle_controller.go +++ b/pkg/controller/nodelifecycle/node_lifecycle_controller.go @@ -797,7 +797,7 @@ func (nc *Controller) processTaintBaseEviction(ctx context.Context, node *v1.Nod logger.Error(nil, "Failed to remove taints from node. Will retry in next iteration", "node", klog.KObj(node)) } if removed { - logger.V(2).Info("Node is healthy again, removing all taints", "node", klog.KObj(node)) + logger.V(2).Info("Node is healthy again, removed all taints", "node", klog.KObj(node)) } } } @@ -1246,12 +1246,12 @@ func (nc *Controller) markNodeAsReachable(ctx context.Context, node *v1.Node) (b err := controller.RemoveTaintOffNode(ctx, nc.kubeClient, node.Name, node, UnreachableTaintTemplate) logger := klog.FromContext(ctx) if err != nil { - logger.Error(err, "Failed to remove taint from node", "node", klog.KObj(node)) + logger.Error(err, "Failed to remove unreachable taint from node", "node", klog.KObj(node)) return false, err } err = controller.RemoveTaintOffNode(ctx, nc.kubeClient, node.Name, node, NotReadyTaintTemplate) if err != nil { - logger.Error(err, "Failed to remove taint from node", "node", klog.KObj(node)) + logger.Error(err, "Failed to remove not-ready taint from node", "node", klog.KObj(node)) return false, err } nc.evictorLock.Lock()