github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 14:07:14 +00:00
Code Issues Projects Releases Wiki Activity

add description for elaborate changes in isZonesEnabled method

Browse Source
This commit is contained in:
Denis Moiseev 2021-04-15 12:20:10 +02:00 committed by Denis Moiseev
parent 273099bd52
commit bfdbfa2ab6
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/legacy-cloud-providers/vsphere/vsphere.go
View File

@ -904,6 +904,10 @@ func (vs *VSphere) LoadBalancer() (cloudprovider.LoadBalancer, bool) {
func (vs *VSphere) isZoneEnabled() bool { func (vs *VSphere) isZoneEnabled() bool {
isEnabled := vs.cfg != nil && vs.cfg.Labels.Zone != "" && vs.cfg.Labels.Region != "" isEnabled := vs.cfg != nil && vs.cfg.Labels.Zone != "" && vs.cfg.Labels.Region != ""
// Return false within kubelet in case of credentials stored in secret.
// Otherwise kubelet will not be able to obtain zone labels from vSphere and create initial node
// due to no credentials at this step.
// See https://github.com/kubernetes/kubernetes/blob/b960f7a0e04687c17e0b0801e17e7cab89f273cc/pkg/kubelet/kubelet_node_status.go#L384-L386
if isEnabled && vs.isSecretInfoProvided && vs.nodeManager.credentialManager == nil { if isEnabled && vs.isSecretInfoProvided && vs.nodeManager.credentialManager == nil {
klog.V(1).Info("Zones can not be populated now due to credentials in Secret, skip.") klog.V(1).Info("Zones can not be populated now due to credentials in Secret, skip.")
return false return false