From bff6ce4a38077c29cdf2e1ac2fce1a551082ebfe Mon Sep 17 00:00:00 2001 From: Monis Khan Date: Mon, 5 Aug 2024 10:50:51 -0400 Subject: [PATCH] ForbiddenStatusError: make linter happy on error construction Signed-off-by: Monis Khan --- .../pkg/endpoints/handlers/responsewriters/errors.go | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/responsewriters/errors.go b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/responsewriters/errors.go index 6c0babfa9f3..07316e802a9 100644 --- a/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/responsewriters/errors.go +++ b/staging/src/k8s.io/apiserver/pkg/endpoints/handlers/responsewriters/errors.go @@ -42,16 +42,16 @@ func Forbidden(ctx context.Context, attributes authorizer.Attributes, w http.Res func ForbiddenStatusError(attributes authorizer.Attributes, reason string) *apierrors.StatusError { msg := sanitizer.Replace(forbiddenMessage(attributes)) - var errMsg string + var errMsg error if len(reason) == 0 { - errMsg = fmt.Sprintf("%s", msg) + errMsg = fmt.Errorf("%s", msg) } else { - errMsg = fmt.Sprintf("%s: %s", msg, reason) + errMsg = fmt.Errorf("%s: %s", msg, reason) } gr := schema.GroupResource{Group: attributes.GetAPIGroup(), Resource: attributes.GetResource()} - return apierrors.NewForbidden(gr, attributes.GetName(), fmt.Errorf(errMsg)) + return apierrors.NewForbidden(gr, attributes.GetName(), errMsg) } func forbiddenMessage(attributes authorizer.Attributes) string {