diff --git a/pkg/scheduler/algorithm/predicates/predicates.go b/pkg/scheduler/algorithm/predicates/predicates.go index 2f6cbe3e76f..c394e2b6310 100644 --- a/pkg/scheduler/algorithm/predicates/predicates.go +++ b/pkg/scheduler/algorithm/predicates/predicates.go @@ -1126,20 +1126,14 @@ func haveOverlap(a1, a2 []string) bool { // that only non-critical pods need and EssentialPredicates are the predicates that all pods, including critical pods, need func GeneralPredicates(pod *v1.Pod, meta PredicateMetadata, nodeInfo *schedulernodeinfo.NodeInfo) (bool, []PredicateFailureReason, error) { var predicateFails []PredicateFailureReason - fit, reasons, err := noncriticalPredicates(pod, meta, nodeInfo) - if err != nil { - return false, predicateFails, err - } - if !fit { - predicateFails = append(predicateFails, reasons...) - } - - fit, reasons, err = EssentialPredicates(pod, meta, nodeInfo) - if err != nil { - return false, predicateFails, err - } - if !fit { - predicateFails = append(predicateFails, reasons...) + for _, predicate := range []FitPredicate{noncriticalPredicates, EssentialPredicates} { + fit, reasons, err := predicate(pod, meta, nodeInfo) + if err != nil { + return false, predicateFails, err + } + if !fit { + predicateFails = append(predicateFails, reasons...) + } } return len(predicateFails) == 0, predicateFails, nil @@ -1162,31 +1156,18 @@ func noncriticalPredicates(pod *v1.Pod, meta PredicateMetadata, nodeInfo *schedu // EssentialPredicates are the predicates that all pods, including critical pods, need func EssentialPredicates(pod *v1.Pod, meta PredicateMetadata, nodeInfo *schedulernodeinfo.NodeInfo) (bool, []PredicateFailureReason, error) { var predicateFails []PredicateFailureReason - fit, reasons, err := PodFitsHost(pod, meta, nodeInfo) - if err != nil { - return false, predicateFails, err - } - if !fit { - predicateFails = append(predicateFails, reasons...) - } - // TODO: PodFitsHostPorts is essential for now, but kubelet should ideally // preempt pods to free up host ports too - fit, reasons, err = PodFitsHostPorts(pod, meta, nodeInfo) - if err != nil { - return false, predicateFails, err - } - if !fit { - predicateFails = append(predicateFails, reasons...) + for _, predicate := range []FitPredicate{PodFitsHost, PodFitsHostPorts, PodMatchNodeSelector} { + fit, reasons, err := predicate(pod, meta, nodeInfo) + if err != nil { + return false, predicateFails, err + } + if !fit { + predicateFails = append(predicateFails, reasons...) + } } - fit, reasons, err = PodMatchNodeSelector(pod, meta, nodeInfo) - if err != nil { - return false, predicateFails, err - } - if !fit { - predicateFails = append(predicateFails, reasons...) - } return len(predicateFails) == 0, predicateFails, nil }