From c065d7c7b3b848afbf26583484a6f3492bec4a7a Mon Sep 17 00:00:00 2001 From: Shiming Zhang Date: Mon, 7 Jun 2021 15:56:30 +0800 Subject: [PATCH] Fix NPE for CSI mounter --- pkg/volume/csi/csi_mounter.go | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/pkg/volume/csi/csi_mounter.go b/pkg/volume/csi/csi_mounter.go index 7e98dea45ca..4193f121443 100644 --- a/pkg/volume/csi/csi_mounter.go +++ b/pkg/volume/csi/csi_mounter.go @@ -392,12 +392,15 @@ func (c *csiMountMgr) supportsFSGroup(fsType string, fsGroup *int64, driverPolic return false } - accessModes := c.spec.PersistentVolume.Spec.AccessModes + if c.spec.PersistentVolume == nil { + klog.V(4).Info(log("mounter.SetupAt Warning: skipping fsGroup permission change, no access mode available. The volume may only be accessible to root users.")) + return false + } if c.spec.PersistentVolume.Spec.AccessModes == nil { klog.V(4).Info(log("mounter.SetupAt WARNING: skipping fsGroup, access modes not provided")) return false } - if !hasReadWriteOnce(accessModes) { + if !hasReadWriteOnce(c.spec.PersistentVolume.Spec.AccessModes) { klog.V(4).Info(log("mounter.SetupAt WARNING: skipping fsGroup, only support ReadWriteOnce access mode")) return false }