From 31fea24c39cccbac2cfbb86bbd37fe71ecd4d70d Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Thu, 2 Apr 2020 15:36:49 +1300 Subject: [PATCH 1/3] Promote Event resource lifecycle test --- test/conformance/testdata/conformance.yaml | 8 ++++++++ test/e2e/framework/events/events.go | 9 ++++++++- 2 files changed, 16 insertions(+), 1 deletion(-) diff --git a/test/conformance/testdata/conformance.yaml b/test/conformance/testdata/conformance.yaml index e7d498c7b59..956f86f4240 100755 --- a/test/conformance/testdata/conformance.yaml +++ b/test/conformance/testdata/conformance.yaml @@ -804,6 +804,14 @@ definitions MUST be published for custom resource definitions. release: v1.16 file: test/e2e/apimachinery/crd_publish_openapi.go +- testname: Event resource lifecycle + codename: '[sig-api-machinery] Events should ensure that an event can be fetched, + patched, deleted, and listed [Conformance]' + description: Create an event, the event MUST exist. The event is patched with a + new message, the check MUST have the update message. The event is deleted and + MUST NOT show up when listing all events. + release: v1.19 + file: test/e2e/framework/events/events.go - testname: Garbage Collector, delete deployment, propagation policy background codename: '[sig-api-machinery] Garbage collector should delete RS created by deployment when not orphaning [Conformance]' diff --git a/test/e2e/framework/events/events.go b/test/e2e/framework/events/events.go index 4890d87f77d..94eaa1230c7 100644 --- a/test/e2e/framework/events/events.go +++ b/test/e2e/framework/events/events.go @@ -39,7 +39,14 @@ type Action func() error var _ = ginkgo.Describe("[sig-api-machinery] Events", func() { f := framework.NewDefaultFramework("events") - ginkgo.It("should ensure that an event can be fetched, patched, deleted, and listed", func() { + /* + Release : v1.19 + Testname: Event resource lifecycle + Description: Create an event, the event MUST exist. + The event is patched with a new message, the check MUST have the update message. + The event is deleted and MUST NOT show up when listing all events. + */ + framework.ConformanceIt("should ensure that an event can be fetched, patched, deleted, and listed", func() { eventTestName := "event-test" ginkgo.By("creating a test event") From 8390de02d040af5edfa284e309b84483ec7764f7 Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Mon, 6 Apr 2020 09:19:54 +1200 Subject: [PATCH 2/3] Fix formatting --- test/e2e/framework/events/events.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/e2e/framework/events/events.go b/test/e2e/framework/events/events.go index 94eaa1230c7..4adb44f93b3 100644 --- a/test/e2e/framework/events/events.go +++ b/test/e2e/framework/events/events.go @@ -40,11 +40,11 @@ var _ = ginkgo.Describe("[sig-api-machinery] Events", func() { f := framework.NewDefaultFramework("events") /* - Release : v1.19 - Testname: Event resource lifecycle - Description: Create an event, the event MUST exist. - The event is patched with a new message, the check MUST have the update message. - The event is deleted and MUST NOT show up when listing all events. + Release : v1.19 + Testname: Event resource lifecycle + Description: Create an event, the event MUST exist. + The event is patched with a new message, the check MUST have the update message. + The event is deleted and MUST NOT show up when listing all events. */ framework.ConformanceIt("should ensure that an event can be fetched, patched, deleted, and listed", func() { eventTestName := "event-test" From b50a710691cb2440a26b1142bdb6a2250a37394b Mon Sep 17 00:00:00 2001 From: Caleb Woodbine Date: Mon, 6 Apr 2020 13:13:10 +1200 Subject: [PATCH 3/3] Fix formatting --- test/e2e/framework/events/events.go | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/test/e2e/framework/events/events.go b/test/e2e/framework/events/events.go index 4adb44f93b3..abd57b7aec7 100644 --- a/test/e2e/framework/events/events.go +++ b/test/e2e/framework/events/events.go @@ -40,11 +40,11 @@ var _ = ginkgo.Describe("[sig-api-machinery] Events", func() { f := framework.NewDefaultFramework("events") /* - Release : v1.19 - Testname: Event resource lifecycle - Description: Create an event, the event MUST exist. - The event is patched with a new message, the check MUST have the update message. - The event is deleted and MUST NOT show up when listing all events. + Release : v1.19 + Testname: Event resource lifecycle + Description: Create an event, the event MUST exist. + The event is patched with a new message, the check MUST have the update message. + The event is deleted and MUST NOT show up when listing all events. */ framework.ConformanceIt("should ensure that an event can be fetched, patched, deleted, and listed", func() { eventTestName := "event-test"