From c183646bafc66416e6d28764e37536ec1a35a065 Mon Sep 17 00:00:00 2001 From: danielqsj Date: Wed, 26 Dec 2018 22:58:56 +0800 Subject: [PATCH] Return admission metrics with true units --- .../src/k8s.io/apiserver/pkg/admission/metrics/metrics.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go index a5ab97a74d5..3a2e021a2b0 100644 --- a/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go +++ b/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go @@ -206,9 +206,9 @@ func (m *metricSet) reset() { // Observe records an observed admission event to all metrics in the metricSet. func (m *metricSet) observe(elapsed time.Duration, labels ...string) { - elapsedMicroseconds := float64(elapsed / time.Microsecond) - m.latencies.WithLabelValues(labels...).Observe(elapsedMicroseconds) + elapsedSeconds := elapsed.Seconds() + m.latencies.WithLabelValues(labels...).Observe(elapsedSeconds) if m.latenciesSummary != nil { - m.latenciesSummary.WithLabelValues(labels...).Observe(elapsedMicroseconds) + m.latenciesSummary.WithLabelValues(labels...).Observe(elapsedSeconds) } }