From c1a40d803c84f3603b3575643440d945908cf63c Mon Sep 17 00:00:00 2001 From: Clayton Coleman Date: Wed, 19 Aug 2015 12:54:08 -0400 Subject: [PATCH] Node controller did not handle an error This means if List() fails nodes are considered deleted (which is bad) --- pkg/controller/node/nodecontroller.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/pkg/controller/node/nodecontroller.go b/pkg/controller/node/nodecontroller.go index 790fbe735fa..5c461ef3033 100644 --- a/pkg/controller/node/nodecontroller.go +++ b/pkg/controller/node/nodecontroller.go @@ -211,6 +211,9 @@ func (nc *NodeController) getCondition(status *api.NodeStatus, conditionType api // not reachable for a long period of time. func (nc *NodeController) monitorNodeStatus() error { nodes, err := nc.kubeClient.Nodes().List(labels.Everything(), fields.Everything()) + if err != nil { + return err + } for _, node := range nodes.Items { if !nc.knownNodeSet.Has(node.Name) { glog.V(1).Infof("NodeController observed a new Node: %#v", node)