mirror of
https://github.com/k3s-io/kubernetes.git
synced 2025-07-24 12:15:52 +00:00
Merge pull request #92216 from weijiehu/azure_managedDiskController_test
Improves unit test code coverage for azure_managedDiskController.go
This commit is contained in:
Kubernetes Prow Robot
GitHub
commit
c241313061
@ -117,6 +117,7 @@ go_test(
|
||||
"azure_controller_vmss_test.go",
|
||||
"azure_instances_test.go",
|
||||
"azure_loadbalancer_test.go",
|
||||
"azure_managedDiskController_test.go",
|
||||
"azure_ratelimit_test.go",
|
||||
"azure_routes_test.go",
|
||||
"azure_standard_test.go",
|
||||
@ -133,6 +134,7 @@ go_test(
|
||||
embed = [":go_default_library"],
|
||||
deps = [
|
||||
"//staging/src/k8s.io/api/core/v1:go_default_library",
|
||||
"//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
|
||||
"//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
|
||||
"//staging/src/k8s.io/apimachinery/pkg/types:go_default_library",
|
||||
"//staging/src/k8s.io/apimachinery/pkg/util/errors:go_default_library",
|
||||
@ -142,6 +144,7 @@ go_test(
|
||||
"//staging/src/k8s.io/client-go/kubernetes/fake:go_default_library",
|
||||
"//staging/src/k8s.io/cloud-provider:go_default_library",
|
||||
"//staging/src/k8s.io/cloud-provider/service/helpers:go_default_library",
|
||||
"//staging/src/k8s.io/cloud-provider/volume:go_default_library",
|
||||
"//staging/src/k8s.io/legacy-cloud-providers/azure/auth:go_default_library",
|
||||
"//staging/src/k8s.io/legacy-cloud-providers/azure/cache:go_default_library",
|
||||
"//staging/src/k8s.io/legacy-cloud-providers/azure/clients:go_default_library",
|
||||
|
||||
@ -0,0 +1,542 @@
|
||||
// +build !providerless
|
||||
|
||||
/*
|
||||
Copyright 2020 The Kubernetes Authors.
|
||||
|
||||
Licensed under the Apache License, Version 2.0 (the "License");
|
||||
you may not use this file except in compliance with the License.
|
||||
You may obtain a copy of the License at
|
||||
|
||||
http://www.apache.org/licenses/LICENSE-2.0
|
||||
|
||||
Unless required by applicable law or agreed to in writing, software
|
||||
distributed under the License is distributed on an "AS IS" BASIS,
|
||||
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
||||
See the License for the specific language governing permissions and
|
||||
limitations under the License.
|
||||
*/
|
||||
|
||||
package azure
|
||||
|
||||
import (
|
||||
"context"
|
||||
"fmt"
|
||||
"strings"
|
||||
"testing"
|
||||
|
||||
"github.com/Azure/azure-sdk-for-go/services/compute/mgmt/2019-12-01/compute"
|
||||
"github.com/Azure/go-autorest/autorest/to"
|
||||
"github.com/golang/mock/gomock"
|
||||
"github.com/stretchr/testify/assert"
|
||||
|
||||
v1 "k8s.io/api/core/v1"
|
||||
"k8s.io/apimachinery/pkg/api/resource"
|
||||
cloudvolume "k8s.io/cloud-provider/volume"
|
||||
"k8s.io/legacy-cloud-providers/azure/clients/diskclient/mockdiskclient"
|
||||
"k8s.io/legacy-cloud-providers/azure/retry"
|
||||
)
|
||||
|
||||
func TestCreateManagedDisk(t *testing.T) {
|
||||
ctrl := gomock.NewController(t)
|
||||
defer ctrl.Finish()
|
||||
|
||||
maxShare := int32(2)
|
||||
goodDiskEncryptionSetID := fmt.Sprintf("/subscriptions/subscription/resourceGroups/rg/providers/Microsoft.Compute/diskEncryptionSets/%s", "diskEncryptionSet-name")
|
||||
badDiskEncryptionSetID := fmt.Sprintf("badDiskEncryptionSetID")
|
||||
testTags := make(map[string]*string)
|
||||
testTags[WriteAcceleratorEnabled] = to.StringPtr("true")
|
||||
testCases := []struct {
|
||||
desc string
|
||||
diskID string
|
||||
diskName string
|
||||
storageAccountType compute.DiskStorageAccountTypes
|
||||
diskIOPSReadWrite string
|
||||
diskMBPSReadWrite string
|
||||
diskEncryptionSetID string
|
||||
expectedDiskID string
|
||||
existedDisk compute.Disk
|
||||
expectedErr bool
|
||||
expectedErrMsg error
|
||||
}{
|
||||
{
|
||||
desc: "disk Id and no error shall be returned if everything is good with UltraSSDLRS storage account",
|
||||
diskID: "diskid1",
|
||||
diskName: "disk1",
|
||||
storageAccountType: compute.UltraSSDLRS,
|
||||
diskIOPSReadWrite: "100",
|
||||
diskMBPSReadWrite: "100",
|
||||
diskEncryptionSetID: goodDiskEncryptionSetID,
|
||||
expectedDiskID: "diskid1",
|
||||
existedDisk: compute.Disk{ID: to.StringPtr("diskid1"), Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{Encryption: &compute.Encryption{DiskEncryptionSetID: &goodDiskEncryptionSetID, Type: compute.EncryptionAtRestWithCustomerKey}, ProvisioningState: to.StringPtr("Succeeded")}, Tags: testTags},
|
||||
expectedErr: false,
|
||||
},
|
||||
{
|
||||
desc: "disk Id and no error shall be returned if everything is good with StandardLRS storage account",
|
||||
diskID: "diskid1",
|
||||
diskName: "disk1",
|
||||
storageAccountType: compute.StandardLRS,
|
||||
diskIOPSReadWrite: "",
|
||||
diskMBPSReadWrite: "",
|
||||
diskEncryptionSetID: goodDiskEncryptionSetID,
|
||||
expectedDiskID: "diskid1",
|
||||
existedDisk: compute.Disk{ID: to.StringPtr("diskid1"), Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{Encryption: &compute.Encryption{DiskEncryptionSetID: &goodDiskEncryptionSetID, Type: compute.EncryptionAtRestWithCustomerKey}, ProvisioningState: to.StringPtr("Succeeded")}, Tags: testTags},
|
||||
expectedErr: false,
|
||||
},
|
||||
{
|
||||
desc: "empty diskid and an error shall be returned if everything is good with UltraSSDLRS storage account but DiskIOPSReadWrite is invalid",
|
||||
diskID: "diskid1",
|
||||
diskName: "disk1",
|
||||
storageAccountType: compute.UltraSSDLRS,
|
||||
diskIOPSReadWrite: "invalid",
|
||||
diskMBPSReadWrite: "100",
|
||||
diskEncryptionSetID: goodDiskEncryptionSetID,
|
||||
expectedDiskID: "",
|
||||
existedDisk: compute.Disk{ID: to.StringPtr("diskid1"), Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{Encryption: &compute.Encryption{DiskEncryptionSetID: &goodDiskEncryptionSetID, Type: compute.EncryptionAtRestWithCustomerKey}, ProvisioningState: to.StringPtr("Succeeded")}, Tags: testTags},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("AzureDisk - failed to parse DiskIOPSReadWrite: strconv.Atoi: parsing \"invalid\": invalid syntax"),
|
||||
},
|
||||
{
|
||||
desc: "empty diskid and an error shall be returned if everything is good with UltraSSDLRS storage account but DiskMBPSReadWrite is invalid",
|
||||
diskID: "diskid1",
|
||||
diskName: "disk1",
|
||||
storageAccountType: compute.UltraSSDLRS,
|
||||
diskIOPSReadWrite: "100",
|
||||
diskMBPSReadWrite: "invalid",
|
||||
diskEncryptionSetID: goodDiskEncryptionSetID,
|
||||
expectedDiskID: "",
|
||||
existedDisk: compute.Disk{ID: to.StringPtr("diskid1"), Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{Encryption: &compute.Encryption{DiskEncryptionSetID: &goodDiskEncryptionSetID, Type: compute.EncryptionAtRestWithCustomerKey}, ProvisioningState: to.StringPtr("Succeeded")}, Tags: testTags},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("AzureDisk - failed to parse DiskMBpsReadWrite: strconv.Atoi: parsing \"invalid\": invalid syntax"),
|
||||
},
|
||||
{
|
||||
desc: "empty diskid and an error shall be returned if everything is good with UltraSSDLRS storage account with bad Disk EncryptionSetID",
|
||||
diskID: "diskid1",
|
||||
diskName: "disk1",
|
||||
storageAccountType: compute.UltraSSDLRS,
|
||||
diskIOPSReadWrite: "100",
|
||||
diskMBPSReadWrite: "100",
|
||||
diskEncryptionSetID: badDiskEncryptionSetID,
|
||||
expectedDiskID: "",
|
||||
existedDisk: compute.Disk{ID: to.StringPtr("diskid1"), Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{Encryption: &compute.Encryption{DiskEncryptionSetID: &goodDiskEncryptionSetID, Type: compute.EncryptionAtRestWithCustomerKey}, ProvisioningState: to.StringPtr("Succeeded")}, Tags: testTags},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("AzureDisk - format of DiskEncryptionSetID(%s) is incorrect, correct format: %s", badDiskEncryptionSetID, diskEncryptionSetIDFormat),
|
||||
},
|
||||
{
|
||||
desc: "disk Id and no error shall be returned if everything is good with StandardLRS storage account with not empty diskIOPSReadWrite",
|
||||
diskID: "diskid1",
|
||||
diskName: "disk1",
|
||||
storageAccountType: compute.StandardLRS,
|
||||
diskIOPSReadWrite: "100",
|
||||
diskMBPSReadWrite: "",
|
||||
diskEncryptionSetID: goodDiskEncryptionSetID,
|
||||
expectedDiskID: "",
|
||||
existedDisk: compute.Disk{ID: to.StringPtr("diskid1"), Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{Encryption: &compute.Encryption{DiskEncryptionSetID: &goodDiskEncryptionSetID, Type: compute.EncryptionAtRestWithCustomerKey}, ProvisioningState: to.StringPtr("Succeeded")}, Tags: testTags},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("AzureDisk - DiskIOPSReadWrite parameter is only applicable in UltraSSD_LRS disk type"),
|
||||
},
|
||||
{
|
||||
desc: "disk Id and no error shall be returned if everything is good with StandardLRS storage account with not empty diskMBPSReadWrite",
|
||||
diskID: "diskid1",
|
||||
diskName: "disk1",
|
||||
storageAccountType: compute.StandardLRS,
|
||||
diskIOPSReadWrite: "",
|
||||
diskMBPSReadWrite: "100",
|
||||
diskEncryptionSetID: goodDiskEncryptionSetID,
|
||||
expectedDiskID: "",
|
||||
existedDisk: compute.Disk{ID: to.StringPtr("diskid1"), Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{Encryption: &compute.Encryption{DiskEncryptionSetID: &goodDiskEncryptionSetID, Type: compute.EncryptionAtRestWithCustomerKey}, ProvisioningState: to.StringPtr("Succeeded")}, Tags: testTags},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("AzureDisk - DiskMBpsReadWrite parameter is only applicable in UltraSSD_LRS disk type"),
|
||||
},
|
||||
}
|
||||
|
||||
for i, test := range testCases {
|
||||
testCloud := GetTestCloud(ctrl)
|
||||
managedDiskController := testCloud.ManagedDiskController
|
||||
volumeOptions := &ManagedDiskOptions{
|
||||
DiskName: test.diskName,
|
||||
StorageAccountType: test.storageAccountType,
|
||||
ResourceGroup: "",
|
||||
SizeGB: 1,
|
||||
Tags: map[string]string{"tag1": "azure-tag1"},
|
||||
AvailabilityZone: "westus-testzone",
|
||||
DiskIOPSReadWrite: test.diskIOPSReadWrite,
|
||||
DiskMBpsReadWrite: test.diskMBPSReadWrite,
|
||||
DiskEncryptionSetID: test.diskEncryptionSetID,
|
||||
MaxShares: maxShare,
|
||||
}
|
||||
|
||||
mockDisksClient := testCloud.DisksClient.(*mockdiskclient.MockInterface)
|
||||
//disk := getTestDisk(test.diskName)
|
||||
mockDisksClient.EXPECT().CreateOrUpdate(gomock.Any(), testCloud.ResourceGroup, test.diskName, gomock.Any()).Return(nil).AnyTimes()
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, nil).AnyTimes()
|
||||
|
||||
actualDiskID, err := managedDiskController.CreateManagedDisk(volumeOptions)
|
||||
assert.Equal(t, test.expectedDiskID, actualDiskID, "TestCase[%d]: %s", i, test.desc)
|
||||
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s, return error: %v", i, test.desc, err)
|
||||
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected error: %v, return error: %v", i, test.desc, test.expectedErrMsg, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestDeleteManagedDisk(t *testing.T) {
|
||||
ctrl := gomock.NewController(t)
|
||||
defer ctrl.Finish()
|
||||
|
||||
fakeGetDiskFailed := "fakeGetDiskFailed"
|
||||
testCases := []struct {
|
||||
desc string
|
||||
diskName string
|
||||
diskState string
|
||||
existedDisk compute.Disk
|
||||
expectedErr bool
|
||||
expectedErrMsg error
|
||||
}{
|
||||
{
|
||||
desc: "an error shall be returned if delete an attaching disk",
|
||||
diskName: "disk1",
|
||||
diskState: "attaching",
|
||||
existedDisk: compute.Disk{Name: to.StringPtr("disk1")},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("failed to delete disk(/subscriptions/subscription/resourceGroups/rg/providers/Microsoft.Compute/disks/disk1) since it's in attaching or detaching state"),
|
||||
},
|
||||
{
|
||||
desc: "no error shall be returned if everything is good",
|
||||
diskName: "disk1",
|
||||
existedDisk: compute.Disk{Name: to.StringPtr("disk1")},
|
||||
expectedErr: false,
|
||||
},
|
||||
{
|
||||
desc: "an error shall be returned if get disk failed",
|
||||
diskName: fakeGetDiskFailed,
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(fakeGetDiskFailed)},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 0, RawError: Get Disk failed"),
|
||||
},
|
||||
}
|
||||
|
||||
for i, test := range testCases {
|
||||
testCloud := GetTestCloud(ctrl)
|
||||
managedDiskController := testCloud.ManagedDiskController
|
||||
diskURI := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/disks/%s",
|
||||
testCloud.SubscriptionID, testCloud.ResourceGroup, *test.existedDisk.Name)
|
||||
if test.diskState == "attaching" {
|
||||
managedDiskController.common.diskAttachDetachMap.Store(strings.ToLower(diskURI), test.diskState)
|
||||
}
|
||||
|
||||
mockDisksClient := testCloud.DisksClient.(*mockdiskclient.MockInterface)
|
||||
if test.diskName == fakeGetDiskFailed {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, &retry.Error{RawError: fmt.Errorf("Get Disk failed")}).AnyTimes()
|
||||
} else {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, nil).AnyTimes()
|
||||
}
|
||||
mockDisksClient.EXPECT().Delete(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(nil).AnyTimes()
|
||||
|
||||
err := managedDiskController.DeleteManagedDisk(diskURI)
|
||||
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s, return error: %v", i, test.desc, err)
|
||||
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected: %v, return: %v", i, test.desc, test.expectedErrMsg, err)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGetDisk(t *testing.T) {
|
||||
ctrl := gomock.NewController(t)
|
||||
defer ctrl.Finish()
|
||||
|
||||
fakeGetDiskFailed := "fakeGetDiskFailed"
|
||||
testCases := []struct {
|
||||
desc string
|
||||
diskName string
|
||||
existedDisk compute.Disk
|
||||
expectedErr bool
|
||||
expectedErrMsg error
|
||||
expectedProvisioningState string
|
||||
expectedDiskID string
|
||||
}{
|
||||
{
|
||||
desc: "no error shall be returned if get a normal disk without DiskProperties",
|
||||
diskName: "disk1",
|
||||
existedDisk: compute.Disk{Name: to.StringPtr("disk1")},
|
||||
expectedErr: false,
|
||||
expectedProvisioningState: "",
|
||||
expectedDiskID: "",
|
||||
},
|
||||
{
|
||||
desc: "an error shall be returned if get disk failed",
|
||||
diskName: fakeGetDiskFailed,
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(fakeGetDiskFailed)},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 0, RawError: Get Disk failed"),
|
||||
expectedProvisioningState: "",
|
||||
expectedDiskID: "",
|
||||
},
|
||||
}
|
||||
|
||||
for i, test := range testCases {
|
||||
testCloud := GetTestCloud(ctrl)
|
||||
managedDiskController := testCloud.ManagedDiskController
|
||||
|
||||
mockDisksClient := testCloud.DisksClient.(*mockdiskclient.MockInterface)
|
||||
if test.diskName == fakeGetDiskFailed {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, &retry.Error{RawError: fmt.Errorf("Get Disk failed")}).AnyTimes()
|
||||
} else {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, nil).AnyTimes()
|
||||
}
|
||||
|
||||
provisioningState, diskid, err := managedDiskController.GetDisk(testCloud.ResourceGroup, test.diskName)
|
||||
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s, return error: %v", i, test.desc, err)
|
||||
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected: %v, return: %v", i, test.desc, test.expectedErrMsg, err)
|
||||
assert.Equal(t, test.expectedProvisioningState, provisioningState, "TestCase[%d]: %s, expected ProvisioningState: %v, return ProvisioningState: %v", i, test.desc, test.expectedProvisioningState, provisioningState)
|
||||
assert.Equal(t, test.expectedDiskID, diskid, "TestCase[%d]: %s, expected DiskID: %v, return DiskID: %v", i, test.desc, test.expectedDiskID, diskid)
|
||||
}
|
||||
}
|
||||
|
||||
func TestResizeDisk(t *testing.T) {
|
||||
ctrl := gomock.NewController(t)
|
||||
defer ctrl.Finish()
|
||||
|
||||
diskSizeGB := int32(2)
|
||||
diskName := "disk1"
|
||||
fakeGetDiskFailed := "fakeGetDiskFailed"
|
||||
fakeCreateDiskFailed := "fakeCreateDiskFailed"
|
||||
testCases := []struct {
|
||||
desc string
|
||||
diskName string
|
||||
oldSize resource.Quantity
|
||||
newSize resource.Quantity
|
||||
existedDisk compute.Disk
|
||||
expectedQuantity resource.Quantity
|
||||
expectedErr bool
|
||||
expectedErrMsg error
|
||||
}{
|
||||
{
|
||||
desc: "new quantity and no error shall be returned if everything is good",
|
||||
diskName: diskName,
|
||||
oldSize: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
newSize: *resource.NewQuantity(3*(1024*1024*1024), resource.BinarySI),
|
||||
existedDisk: compute.Disk{Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}},
|
||||
expectedQuantity: *resource.NewQuantity(3*(1024*1024*1024), resource.BinarySI),
|
||||
expectedErr: false,
|
||||
},
|
||||
{
|
||||
desc: "new quantity and no error shall be returned if everything is good with DiskProperties is null",
|
||||
diskName: diskName,
|
||||
oldSize: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
newSize: *resource.NewQuantity(3*(1024*1024*1024), resource.BinarySI),
|
||||
existedDisk: compute.Disk{Name: to.StringPtr("disk1")},
|
||||
expectedQuantity: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("DiskProperties of disk(%s) is nil", diskName),
|
||||
},
|
||||
{
|
||||
desc: "new quantity and no error shall be returned if everything is good with disk already of greater or equal size than requested",
|
||||
diskName: diskName,
|
||||
oldSize: *resource.NewQuantity(1*(1024*1024*1024), resource.BinarySI),
|
||||
newSize: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
existedDisk: compute.Disk{Name: to.StringPtr("disk1"), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}},
|
||||
expectedQuantity: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
expectedErr: false,
|
||||
},
|
||||
{
|
||||
desc: "an error shall be returned if everything is good but get disk failed",
|
||||
diskName: fakeGetDiskFailed,
|
||||
oldSize: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
newSize: *resource.NewQuantity(3*(1024*1024*1024), resource.BinarySI),
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(fakeGetDiskFailed), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}},
|
||||
expectedQuantity: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 0, RawError: Get Disk failed"),
|
||||
},
|
||||
{
|
||||
desc: "an error shall be returned if everything is good but create disk failed",
|
||||
diskName: fakeCreateDiskFailed,
|
||||
oldSize: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
newSize: *resource.NewQuantity(3*(1024*1024*1024), resource.BinarySI),
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(fakeCreateDiskFailed), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}},
|
||||
expectedQuantity: *resource.NewQuantity(2*(1024*1024*1024), resource.BinarySI),
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 0, RawError: Create Disk failed"),
|
||||
},
|
||||
}
|
||||
|
||||
for i, test := range testCases {
|
||||
testCloud := GetTestCloud(ctrl)
|
||||
managedDiskController := testCloud.ManagedDiskController
|
||||
diskURI := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/disks/%s",
|
||||
testCloud.SubscriptionID, testCloud.ResourceGroup, *test.existedDisk.Name)
|
||||
|
||||
mockDisksClient := testCloud.DisksClient.(*mockdiskclient.MockInterface)
|
||||
if test.diskName == fakeGetDiskFailed {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, &retry.Error{RawError: fmt.Errorf("Get Disk failed")}).AnyTimes()
|
||||
} else {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, nil).AnyTimes()
|
||||
}
|
||||
if test.diskName == fakeCreateDiskFailed {
|
||||
mockDisksClient.EXPECT().CreateOrUpdate(gomock.Any(), testCloud.ResourceGroup, test.diskName, gomock.Any()).Return(&retry.Error{RawError: fmt.Errorf("Create Disk failed")}).AnyTimes()
|
||||
} else {
|
||||
mockDisksClient.EXPECT().CreateOrUpdate(gomock.Any(), testCloud.ResourceGroup, test.diskName, gomock.Any()).Return(nil).AnyTimes()
|
||||
}
|
||||
|
||||
result, err := managedDiskController.ResizeDisk(diskURI, test.oldSize, test.newSize)
|
||||
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s, return error: %v", i, test.desc, err)
|
||||
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected: %v, return: %v", i, test.desc, test.expectedErrMsg, err)
|
||||
assert.Equal(t, test.expectedQuantity.Value(), result.Value(), "TestCase[%d]: %s, expected Quantity: %v, return Quantity: %v", i, test.desc, test.expectedQuantity, result)
|
||||
}
|
||||
}
|
||||
|
||||
func TestGetLabelsForVolume(t *testing.T) {
|
||||
ctrl := gomock.NewController(t)
|
||||
defer ctrl.Finish()
|
||||
|
||||
testCloud0 := GetTestCloud(ctrl)
|
||||
diskName := "disk1"
|
||||
diskURI := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/disks/%s",
|
||||
testCloud0.SubscriptionID, testCloud0.ResourceGroup, diskName)
|
||||
diskSizeGB := int32(30)
|
||||
fakeGetDiskFailed := "fakeGetDiskFailed"
|
||||
fakeGetDiskFailedDiskURI := fmt.Sprintf("/subscriptions/%s/resourceGroups/%s/providers/Microsoft.Compute/disks/%s",
|
||||
testCloud0.SubscriptionID, testCloud0.ResourceGroup, fakeGetDiskFailed)
|
||||
testCases := []struct {
|
||||
desc string
|
||||
diskName string
|
||||
pv *v1.PersistentVolume
|
||||
existedDisk compute.Disk
|
||||
expected map[string]string
|
||||
expectedErr bool
|
||||
expectedErrMsg error
|
||||
}{
|
||||
{
|
||||
desc: "labels and no error shall be returned if everything is good",
|
||||
diskName: diskName,
|
||||
pv: &v1.PersistentVolume{
|
||||
Spec: v1.PersistentVolumeSpec{
|
||||
PersistentVolumeSource: v1.PersistentVolumeSource{
|
||||
AzureDisk: &v1.AzureDiskVolumeSource{
|
||||
DiskName: diskName,
|
||||
DataDiskURI: diskURI,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(diskName), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}, Zones: &[]string{"1"}},
|
||||
expected: map[string]string{
|
||||
v1.LabelZoneRegion: testCloud0.Location,
|
||||
v1.LabelZoneFailureDomain: testCloud0.makeZone(testCloud0.Location, 1),
|
||||
},
|
||||
expectedErr: false,
|
||||
},
|
||||
{
|
||||
desc: "an error shall be returned if everything is good with invalid zone",
|
||||
diskName: diskName,
|
||||
pv: &v1.PersistentVolume{
|
||||
Spec: v1.PersistentVolumeSpec{
|
||||
PersistentVolumeSource: v1.PersistentVolumeSource{
|
||||
AzureDisk: &v1.AzureDiskVolumeSource{
|
||||
DiskName: diskName,
|
||||
DataDiskURI: diskURI,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(diskName), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}, Zones: &[]string{"invalid"}},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("failed to parse zone [invalid] for AzureDisk %v: %v", diskName, "strconv.Atoi: parsing \"invalid\": invalid syntax"),
|
||||
},
|
||||
{
|
||||
desc: "nil shall be returned if everything is good with null Zones",
|
||||
diskName: diskName,
|
||||
pv: &v1.PersistentVolume{
|
||||
Spec: v1.PersistentVolumeSpec{
|
||||
PersistentVolumeSource: v1.PersistentVolumeSource{
|
||||
AzureDisk: &v1.AzureDiskVolumeSource{
|
||||
DiskName: diskName,
|
||||
DataDiskURI: diskURI,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(diskName), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}},
|
||||
expected: map[string]string{
|
||||
v1.LabelZoneRegion: testCloud0.Location,
|
||||
},
|
||||
expectedErr: false,
|
||||
expectedErrMsg: nil,
|
||||
},
|
||||
{
|
||||
desc: "an error shall be returned if everything is good with get disk failed",
|
||||
diskName: fakeGetDiskFailed,
|
||||
pv: &v1.PersistentVolume{
|
||||
Spec: v1.PersistentVolumeSpec{
|
||||
PersistentVolumeSource: v1.PersistentVolumeSource{
|
||||
AzureDisk: &v1.AzureDiskVolumeSource{
|
||||
DiskName: fakeGetDiskFailed,
|
||||
DataDiskURI: fakeGetDiskFailedDiskURI,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(fakeGetDiskFailed), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}, Zones: &[]string{"1"}},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("Retriable: false, RetryAfter: 0s, HTTPStatusCode: 0, RawError: Get Disk failed"),
|
||||
},
|
||||
{
|
||||
desc: "an error shall be returned if everything is good with invalid DiskURI",
|
||||
diskName: diskName,
|
||||
pv: &v1.PersistentVolume{
|
||||
Spec: v1.PersistentVolumeSpec{
|
||||
PersistentVolumeSource: v1.PersistentVolumeSource{
|
||||
AzureDisk: &v1.AzureDiskVolumeSource{
|
||||
DiskName: diskName,
|
||||
DataDiskURI: "invalidDiskURI",
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(diskName), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}, Zones: &[]string{"1"}},
|
||||
expectedErr: true,
|
||||
expectedErrMsg: fmt.Errorf("invalid disk URI: invalidDiskURI"),
|
||||
},
|
||||
{
|
||||
desc: "nil shall be returned if everything is good but pv.Spec.AzureDisk.DiskName is cloudvolume.ProvisionedVolumeName",
|
||||
diskName: diskName,
|
||||
pv: &v1.PersistentVolume{
|
||||
Spec: v1.PersistentVolumeSpec{
|
||||
PersistentVolumeSource: v1.PersistentVolumeSource{
|
||||
AzureDisk: &v1.AzureDiskVolumeSource{
|
||||
DiskName: cloudvolume.ProvisionedVolumeName,
|
||||
DataDiskURI: diskURI,
|
||||
},
|
||||
},
|
||||
},
|
||||
},
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(diskName), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}},
|
||||
expected: nil,
|
||||
expectedErr: false,
|
||||
},
|
||||
{
|
||||
desc: "nil shall be returned if everything is good but pv.Spec.AzureDisk is nil",
|
||||
diskName: diskName,
|
||||
pv: &v1.PersistentVolume{
|
||||
Spec: v1.PersistentVolumeSpec{
|
||||
PersistentVolumeSource: v1.PersistentVolumeSource{},
|
||||
},
|
||||
},
|
||||
existedDisk: compute.Disk{Name: to.StringPtr(diskName), DiskProperties: &compute.DiskProperties{DiskSizeGB: &diskSizeGB}},
|
||||
expected: nil,
|
||||
expectedErr: false,
|
||||
},
|
||||
}
|
||||
|
||||
for i, test := range testCases {
|
||||
testCloud := GetTestCloud(ctrl)
|
||||
mockDisksClient := testCloud.DisksClient.(*mockdiskclient.MockInterface)
|
||||
if test.diskName == fakeGetDiskFailed {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, &retry.Error{RawError: fmt.Errorf("Get Disk failed")}).AnyTimes()
|
||||
} else {
|
||||
mockDisksClient.EXPECT().Get(gomock.Any(), testCloud.ResourceGroup, test.diskName).Return(test.existedDisk, nil).AnyTimes()
|
||||
}
|
||||
mockDisksClient.EXPECT().CreateOrUpdate(gomock.Any(), testCloud.ResourceGroup, test.diskName, gomock.Any()).Return(nil).AnyTimes()
|
||||
|
||||
result, err := testCloud.GetLabelsForVolume(context.TODO(), test.pv)
|
||||
assert.Equal(t, test.expected, result, "TestCase[%d]: %s, expected: %v, return: %v", i, test.desc, test.expected, result)
|
||||
assert.Equal(t, test.expectedErr, err != nil, "TestCase[%d]: %s, return error: %v", i, test.desc, err)
|
||||
assert.Equal(t, test.expectedErrMsg, err, "TestCase[%d]: %s, expected: %v, return: %v", i, test.desc, test.expectedErrMsg, err)
|
||||
}
|
||||
}
|
||||
Loading…
Reference in New Issue
Block a user