github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-07 11:13:48 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #121697 from carlory/clean-111

Browse Source 
add comments for switch case of syncUnboundClaim
This commit is contained in:
Kubernetes Prow Robot 2023-12-13 22:35:00 +01:00 committed by GitHub
commit c24e8ee403
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
pkg/controller/volume/persistentvolume/pv_controller.go
View File

@ -346,7 +346,7 @@ func (ctrl *PersistentVolumeController) syncUnboundClaim(ctx context.Context, cl
} }
if volume == nil { if volume == nil {
logger.V(4).Info("Synchronizing unbound PersistentVolumeClaim, no volume found", "PVC", klog.KObj(claim)) logger.V(4).Info("Synchronizing unbound PersistentVolumeClaim, no volume found", "PVC", klog.KObj(claim))
// No PV could be found // No PV could be found. Try to provision one if possible.
// OBSERVATION: pvc is "Pending", will retry // OBSERVATION: pvc is "Pending", will retry
logger.V(4).Info("Attempting to assign storage class to unbound PersistentVolumeClaim", "PVC", klog.KObj(claim)) logger.V(4).Info("Attempting to assign storage class to unbound PersistentVolumeClaim", "PVC", klog.KObj(claim))
@ -363,10 +363,15 @@ func (ctrl *PersistentVolumeController) syncUnboundClaim(ctx context.Context, cl
switch { switch {
case delayBinding && !storagehelpers.IsDelayBindingProvisioning(claim): case delayBinding && !storagehelpers.IsDelayBindingProvisioning(claim):
// Scheduler does not observe any pod using this claim.
if err = ctrl.emitEventForUnboundDelayBindingClaim(claim); err != nil { if err = ctrl.emitEventForUnboundDelayBindingClaim(claim); err != nil {
return err return err
} }
case storagehelpers.GetPersistentVolumeClaimClass(claim) != "": case storagehelpers.GetPersistentVolumeClaimClass(claim) != "":
// The provisionClaim function may start a new asynchronous operation to provision a volume,
// or the operation is already running. The claim will be updated in the asynchronous operation,
// so the branch should be returned directly and the bind operation is expected to continue in
// the next sync loop.
if err = ctrl.provisionClaim(ctx, claim); err != nil { if err = ctrl.provisionClaim(ctx, claim); err != nil {
return err return err
} }