github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-02 08:17:26 +00:00
Code Issues Projects Releases Wiki Activity

improve edit experience

Browse Source
This commit is contained in:
ymqytw 2016-09-23 11:12:24 -07:00
parent 049a023625
commit c27f99b89e
1 changed files with 10 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
pkg/kubectl/cmd/edit.go
View File

@ -39,6 +39,7 @@ import (
"k8s.io/kubernetes/pkg/runtime" "k8s.io/kubernetes/pkg/runtime"
"k8s.io/kubernetes/pkg/util/crlf" "k8s.io/kubernetes/pkg/util/crlf"
"k8s.io/kubernetes/pkg/util/strategicpatch" "k8s.io/kubernetes/pkg/util/strategicpatch"
"k8s.io/kubernetes/pkg/util/validation/field"
"k8s.io/kubernetes/pkg/util/yaml" "k8s.io/kubernetes/pkg/util/yaml"
"github.com/golang/glog" "github.com/golang/glog"
@ -216,7 +217,12 @@ func RunEdit(f *cmdutil.Factory, out, errOut io.Writer, cmd *cobra.Command, args
} }
err = schema.ValidateBytes(stripComments(edited)) err = schema.ValidateBytes(stripComments(edited))
if err != nil { if err != nil {
return preservedFile(err, file, errOut) results = editResults{
file: file,
}
containsError = true
fmt.Fprintln(out, results.addError(errors.NewInvalid(api.Kind(""), "", field.ErrorList{field.Invalid(nil, "The edited file failed validation", fmt.Sprintf("%v", err))}), info))
continue
} }
// Compare content without comments // Compare content without comments
@ -295,8 +301,9 @@ func RunEdit(f *cmdutil.Factory, out, errOut io.Writer, cmd *cobra.Command, args
return nil return nil
} }
// loop again and edit the remaining items if len(results.header.reasons) > 0 {
infos = results.edit containsError = true
}
} }
}) })
return err return err