github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-15 23:03:40 +00:00
Code Issues Projects Releases Wiki Activity

kubeadm: do not poll in TestEnsureAdminClusterRoleBindingImpl

Browse Source 
In EnsureAdminClusterRoleBindingImpl() there are a couple of
polls around CRB create calls. When testing the function
a short retry and a timeout are used. These introduce around
2x20 fake client "connections" / poll iterations under a couple
of test cases with 2 seconds overall test increase.

Given the polls in EnsureAdminClusterRoleBindingImpl()
are of type PollUntilContextTimeout() with "immediate" set to "true",
the short retry / time out can be removed when testing,
because one poll iteration is guaranteed and the tested function
is at 100% coverage with reactors and test cases.
This commit is contained in:
Lubomir I. Ivanov 2023-10-31 17:37:10 +02:00
parent 05076de57f
commit c2a365c6a7
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
cmd/kubeadm/app/phases/kubeconfig/kubeconfig_test.go
View File

@ -933,7 +933,7 @@ func TestEnsureAdminClusterRoleBindingImpl(t *testing.T) {
}
client, err := EnsureAdminClusterRoleBindingImpl(
context.Background(), adminClient, superAdminClient, time.Millisecond*50, time.Millisecond*1000)
context.Background(), adminClient, superAdminClient, 0, 0)
if (err != nil) != tc.expectedError {
t.Fatalf("expected error: %v, got %v, error: %v", tc.expectedError, err != nil, err)
}