From 97bca0ec59208d4b0f67c3ee73d2b68311b07518 Mon Sep 17 00:00:00 2001
From: Yuiko Mori <yuiko-mori@nec.com>
Date: Tue, 16 Jun 2020 01:13:32 +0000
Subject: [PATCH] Add Deprecated description to metrics
 scheduling_duration_seconds

---
 pkg/controller/volume/scheduling/metrics/metrics.go | 11 ++++++-----
 pkg/scheduler/metrics/metrics.go                    |  6 +++---
 2 files changed, 9 insertions(+), 8 deletions(-)

diff --git a/pkg/controller/volume/scheduling/metrics/metrics.go b/pkg/controller/volume/scheduling/metrics/metrics.go
index 808fd6d5783..1ad451bbfe2 100644
--- a/pkg/controller/volume/scheduling/metrics/metrics.go
+++ b/pkg/controller/volume/scheduling/metrics/metrics.go
@@ -38,11 +38,12 @@ var (
 	// VolumeSchedulingStageLatency tracks the latency of volume scheduling operations.
 	VolumeSchedulingStageLatency = metrics.NewHistogramVec(
 		&metrics.HistogramOpts{
-			Subsystem:      VolumeSchedulerSubsystem,
-			Name:           "scheduling_duration_seconds",
-			Help:           "Volume scheduling stage latency",
-			Buckets:        metrics.ExponentialBuckets(1000, 2, 15),
-			StabilityLevel: metrics.ALPHA,
+			Subsystem:         VolumeSchedulerSubsystem,
+			Name:              "scheduling_duration_seconds",
+			Help:              "Volume scheduling stage latency (Deprecated since 1.19.0)",
+			Buckets:           metrics.ExponentialBuckets(1000, 2, 15),
+			StabilityLevel:    metrics.ALPHA,
+			DeprecatedVersion: "1.19.0",
 		},
 		[]string{"operation"},
 	)
diff --git a/pkg/scheduler/metrics/metrics.go b/pkg/scheduler/metrics/metrics.go
index f5bbd164858..3b4e0629672 100644
--- a/pkg/scheduler/metrics/metrics.go
+++ b/pkg/scheduler/metrics/metrics.go
@@ -68,7 +68,7 @@ var (
 		&metrics.SummaryOpts{
 			Subsystem: SchedulerSubsystem,
 			Name:      DeprecatedSchedulingDurationName,
-			Help:      "Scheduling latency in seconds split by sub-parts of the scheduling operation",
+			Help:      "Scheduling latency in seconds split by sub-parts of the scheduling operation (Deprecated since 1.19.0)",
 			// Make the sliding window of 5h.
 			// TODO: The value for this should be based on some SLI definition (long term).
 			MaxAge:            5 * time.Hour,
@@ -99,7 +99,7 @@ var (
 		&metrics.HistogramOpts{
 			Subsystem:         SchedulerSubsystem,
 			Name:              "scheduling_algorithm_predicate_evaluation_seconds",
-			Help:              "Scheduling algorithm predicate evaluation duration in seconds",
+			Help:              "Scheduling algorithm predicate evaluation duration in seconds (Deprecated since 1.19.0)",
 			Buckets:           metrics.ExponentialBuckets(0.001, 2, 15),
 			StabilityLevel:    metrics.ALPHA,
 			DeprecatedVersion: "1.19.0",
@@ -109,7 +109,7 @@ var (
 		&metrics.HistogramOpts{
 			Subsystem:         SchedulerSubsystem,
 			Name:              "scheduling_algorithm_priority_evaluation_seconds",
-			Help:              "Scheduling algorithm priority evaluation duration in seconds",
+			Help:              "Scheduling algorithm priority evaluation duration in seconds (Deprecated since 1.19.0)",
 			Buckets:           metrics.ExponentialBuckets(0.001, 2, 15),
 			StabilityLevel:    metrics.ALPHA,
 			DeprecatedVersion: "1.19.0",