From b8781473051953b4cbbeb65c1b6699471d773e2e Mon Sep 17 00:00:00 2001 From: Yassine TIJANI Date: Thu, 1 Jun 2017 11:03:40 +0200 Subject: [PATCH] removing unnecessary shallow copy see #46703 --- pkg/controller/endpoint/endpoints_controller.go | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/pkg/controller/endpoint/endpoints_controller.go b/pkg/controller/endpoint/endpoints_controller.go index df5db13e6f2..dae2c399d2f 100644 --- a/pkg/controller/endpoint/endpoints_controller.go +++ b/pkg/controller/endpoint/endpoints_controller.go @@ -338,9 +338,7 @@ func (e *EndpointController) syncService(key string) error { readyEps := 0 notReadyEps := 0 - for i := range pods { - // TODO: Do we need to copy here? - pod := &(*pods[i]) + for _, pod := range pods { for i := range service.Spec.Ports { servicePort := &service.Spec.Ports[i]