github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-26 21:17:23 +00:00
Code Issues Projects Releases Wiki Activity

Remove confusing function; add TODO and explanation for (nonfatal) error message in integration test.

Browse Source
This commit is contained in:
Daniel Smith 2014-11-14 17:16:05 -08:00
parent 4681918888
commit c412540cf2
2 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
cmd/integration/integration.go
View File

@ -646,6 +646,7 @@ func ServeCachedManifestFile() (servingAddress string) {
const ( const (
// This is copied from, and should be kept in sync with: // This is copied from, and should be kept in sync with:
// https://raw.githubusercontent.com/GoogleCloudPlatform/container-vm-guestbook-redis-python/master/manifest.yaml // https://raw.githubusercontent.com/GoogleCloudPlatform/container-vm-guestbook-redis-python/master/manifest.yaml
// Note that kubelet complains about these containers not having a self link.
testManifestFile = `version: v1beta2 testManifestFile = `version: v1beta2
id: container-vm-guestbook id: container-vm-guestbook
containers: containers:

8
pkg/kubelet/kubelet.go
View File

@ -268,11 +268,6 @@ func (self *podWorkers) Run(podFullName string, action func()) {
}() }()
} }
// LogEvent reports an event.
func (kl *Kubelet) LogEvent(event *api.Event) error {
return nil
}
func makeEnvironmentVariables(container *api.Container) []string { func makeEnvironmentVariables(container *api.Container) []string {
var result []string var result []string
for _, value := range container.Env { for _, value := range container.Env {
@ -404,6 +399,9 @@ func fieldPath(pod *api.BoundPod, container *api.Container) (string, error) {
// containerRef returns an *api.ObjectReference which references the given container within the // containerRef returns an *api.ObjectReference which references the given container within the
// given pod. Returns an error if the reference can't be constructed or the container doesn't // given pod. Returns an error if the reference can't be constructed or the container doesn't
// actually belong to the pod. // actually belong to the pod.
// TODO: Pods that came to us by static config or over HTTP have no selfLink set, which makes
// this fail and log an error. Figure out how we want to identify these pods to the rest of the
// system.
func containerRef(pod *api.BoundPod, container *api.Container) (*api.ObjectReference, error) { func containerRef(pod *api.BoundPod, container *api.Container) (*api.ObjectReference, error) {
fieldPath, err := fieldPath(pod, container) fieldPath, err := fieldPath(pod, container)
if err != nil { if err != nil {