From c429b7d3e49f29ac86f167334c1af362d64838ee Mon Sep 17 00:00:00 2001 From: Ted Yu Date: Wed, 17 Jul 2019 10:52:21 -0700 Subject: [PATCH] Handle error return from MetaNamespaceKeyFunc --- pkg/controller/daemon/daemon_controller.go | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/pkg/controller/daemon/daemon_controller.go b/pkg/controller/daemon/daemon_controller.go index 11fc71eb598..c23d9b69845 100644 --- a/pkg/controller/daemon/daemon_controller.go +++ b/pkg/controller/daemon/daemon_controller.go @@ -876,7 +876,11 @@ func (dsc *DaemonSetsController) podsShouldBeOnNode( } daemonPods, exists := nodeToDaemonPods[node.Name] - dsKey, _ := cache.MetaNamespaceKeyFunc(ds) + dsKey, err := cache.MetaNamespaceKeyFunc(ds) + if err != nil { + utilruntime.HandleError(err) + return + } dsc.removeSuspendedDaemonPods(node.Name, dsKey)