Merge pull request #80247 from jsafrane/e2e-volume-limits

Add e2e test for CSI volume limits

test/e2e/storage/csi_volumes.go

@@ -52,6 +52,7 @@ var csiTestSuites = []func() testsuites.TestSuite{
 	testsuites.InitMultiVolumeTestSuite,
 	testsuites.InitDisruptiveTestSuite,
 	testsuites.InitVolumeExpandTestSuite,
+	testsuites.InitVolumeLimitsTestSuite,
 }
 
 // This executes testSuites for csi volumes.

test/e2e/storage/drivers/csi.go

@@ -252,9 +252,10 @@ func InitMockCSIDriver(driverOpts CSIMockDriverOpts) testsuites.TestDriver {
 				"", // Default fsType
 			),
 			Capabilities: map[testsuites.Capability]bool{
-				testsuites.CapPersistence: false,
-				testsuites.CapFsGroup:     false,
-				testsuites.CapExec:        false,
+				testsuites.CapPersistence:  false,
+				testsuites.CapFsGroup:      false,
+				testsuites.CapExec:         false,
+				testsuites.CapVolumeLimits: true,
 			},
 		},
 		manifests:           driverManifests,
@@ -387,6 +388,9 @@ func InitGcePDCSIDriver() testsuites.TestDriver {
 				testsuites.CapFsGroup:     true,
 				testsuites.CapExec:        true,
 				testsuites.CapMultiPODs:   true,
+				// GCE supports volume limits, but the test creates large
+				// number of volumes and times out test suites.
+				testsuites.CapVolumeLimits: false,
 			},
 			RequiredAccessModes: []v1.PersistentVolumeAccessMode{v1.ReadWriteOnce},
 		},

test/e2e/storage/drivers/in_tree.go

@@ -988,6 +988,9 @@ func InitCinderDriver() testsuites.TestDriver {
 				testsuites.CapPersistence: true,
 				testsuites.CapFsGroup:     true,
 				testsuites.CapExec:        true,
+				// Cinder supports volume limits, but the test creates large
+				// number of volumes and times out test suites.
+				testsuites.CapVolumeLimits: false,
 			},
 		},
 	}
@@ -1159,6 +1162,9 @@ func InitGcePdDriver() testsuites.TestDriver {
 				testsuites.CapMultiPODs:           true,
 				testsuites.CapControllerExpansion: true,
 				testsuites.CapNodeExpansion:       true,
+				// GCE supports volume limits, but the test creates large
+				// number of volumes and times out test suites.
+				testsuites.CapVolumeLimits: false,
 			},
 		},
 	}
@@ -1413,6 +1419,9 @@ func InitAzureDriver() testsuites.TestDriver {
 				testsuites.CapBlock:       true,
 				testsuites.CapExec:        true,
 				testsuites.CapMultiPODs:   true,
+				// Azure supports volume limits, but the test creates large
+				// number of volumes and times out test suites.
+				testsuites.CapVolumeLimits: false,
 			},
 		},
 	}
@@ -1537,6 +1546,9 @@ func InitAwsDriver() testsuites.TestDriver {
 				testsuites.CapMultiPODs:           true,
 				testsuites.CapControllerExpansion: true,
 				testsuites.CapNodeExpansion:       true,
+				// AWS supports volume limits, but the test creates large
+				// number of volumes and times out test suites.
+				testsuites.CapVolumeLimits: false,
 			},
 		},
 	}

test/e2e/storage/external/external.go

@@ -50,6 +50,7 @@ var csiTestSuites = []func() testsuites.TestSuite{
 	testsuites.InitVolumesTestSuite,
 	testsuites.InitVolumeExpandTestSuite,
 	testsuites.InitDisruptiveTestSuite,
+	testsuites.InitVolumeLimitsTestSuite,
 }
 
 func init() {

test/e2e/storage/in_tree_volumes.go

@@ -58,6 +58,7 @@ var testSuites = []func() testsuites.TestSuite{
 	testsuites.InitMultiVolumeTestSuite,
 	testsuites.InitVolumeExpandTestSuite,
 	testsuites.InitDisruptiveTestSuite,
+	testsuites.InitVolumeLimitsTestSuite,
 }
 
 // This executes testSuites for in-tree volumes.

test/e2e/storage/testsuites/BUILD

@@ -14,6 +14,7 @@ go_library(
         "testdriver.go",
         "volume_expand.go",
         "volume_io.go",
+        "volumelimits.go",
         "volumemode.go",
         "volumes.go",
     ],
@@ -22,8 +23,10 @@ go_library(
     deps = [
         "//pkg/controller/volume/events:go_default_library",
         "//pkg/kubelet/events:go_default_library",
+        "//pkg/volume/util:go_default_library",
         "//staging/src/k8s.io/api/core/v1:go_default_library",
         "//staging/src/k8s.io/api/storage/v1:go_default_library",
+        "//staging/src/k8s.io/api/storage/v1beta1:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/api/errors:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/api/resource:go_default_library",
         "//staging/src/k8s.io/apimachinery/pkg/apis/meta/v1:go_default_library",
@@ -39,6 +42,7 @@ go_library(
         "//staging/src/k8s.io/client-go/dynamic:go_default_library",
         "//staging/src/k8s.io/client-go/kubernetes:go_default_library",
         "//staging/src/k8s.io/csi-translation-lib:go_default_library",
+        "//staging/src/k8s.io/csi-translation-lib/plugins:go_default_library",
         "//test/e2e/common:go_default_library",
         "//test/e2e/framework:go_default_library",
         "//test/e2e/framework/log:go_default_library",

test/e2e/storage/testsuites/testdriver.go

@@ -17,7 +17,7 @@ limitations under the License.
 package testsuites
 
 import (
-	"k8s.io/api/core/v1"
+	v1 "k8s.io/api/core/v1"
 	storagev1 "k8s.io/api/storage/v1"
 	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
 	"k8s.io/apimachinery/pkg/util/sets"
@@ -155,6 +155,7 @@ const (
 	CapRWX                 Capability = "RWX"                 // support ReadWriteMany access modes
 	CapControllerExpansion Capability = "controllerExpansion" // support volume expansion for controller
 	CapNodeExpansion       Capability = "nodeExpansion"       // support volume expansion for node
+	CapVolumeLimits                   = "volumeLimits"        // support volume limits (can be *very* slow)
 )
 
 // DriverInfo represents static information about a TestDriver.

test/e2e/storage/testsuites/volumelimits.go

@@ -0,0 +1,343 @@
+/*
+Copyright 2019 The Kubernetes Authors.
+
+Licensed under the Apache License, Version 2.0 (the "License");
+you may not use this file except in compliance with the License.
+You may obtain a copy of the License at
+
+    http://www.apache.org/licenses/LICENSE-2.0
+
+Unless required by applicable law or agreed to in writing, software
+distributed under the License is distributed on an "AS IS" BASIS,
+WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+See the License for the specific language governing permissions and
+limitations under the License.
+*/
+
+package testsuites
+
+import (
+	"fmt"
+	"regexp"
+	"strings"
+	"time"
+
+	"github.com/onsi/ginkgo"
+
+	v1 "k8s.io/api/core/v1"
+	storagev1beta1 "k8s.io/api/storage/v1beta1"
+	"k8s.io/apimachinery/pkg/api/errors"
+	metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
+	"k8s.io/apimachinery/pkg/util/sets"
+	"k8s.io/apimachinery/pkg/util/wait"
+	clientset "k8s.io/client-go/kubernetes"
+	migrationplugins "k8s.io/csi-translation-lib/plugins" // volume plugin names are exported nicely there
+	volumeutil "k8s.io/kubernetes/pkg/volume/util"
+	"k8s.io/kubernetes/test/e2e/framework"
+	e2epod "k8s.io/kubernetes/test/e2e/framework/pod"
+	"k8s.io/kubernetes/test/e2e/storage/testpatterns"
+)
+
+type volumeLimitsTestSuite struct {
+	tsInfo TestSuiteInfo
+}
+
+const (
+	// The test uses generic pod startup / PV deletion timeouts. As it creates
+	// much more volumes at once, these timeouts are multiplied by this number.
+	// Using real nr. of volumes (e.g. 128 on GCE) would be really too much.
+	testSlowMultiplier = 10
+
+	// How long to wait until CSINode gets attach limit from installed CSI driver.
+	csiNodeInfoTimeout = 1 * time.Minute
+)
+
+var _ TestSuite = &volumeLimitsTestSuite{}
+
+// InitVolumeLimitsTestSuite returns volumeLimitsTestSuite that implements TestSuite interface
+func InitVolumeLimitsTestSuite() TestSuite {
+	return &volumeLimitsTestSuite{
+		tsInfo: TestSuiteInfo{
+			name: "volumeLimits",
+			testPatterns: []testpatterns.TestPattern{
+				testpatterns.FsVolModeDynamicPV,
+			},
+		},
+	}
+}
+
+func (t *volumeLimitsTestSuite) getTestSuiteInfo() TestSuiteInfo {
+	return t.tsInfo
+}
+
+func (t *volumeLimitsTestSuite) skipRedundantSuite(driver TestDriver, pattern testpatterns.TestPattern) {
+}
+
+func (t *volumeLimitsTestSuite) defineTests(driver TestDriver, pattern testpatterns.TestPattern) {
+	type local struct {
+		config      *PerTestConfig
+		testCleanup func()
+
+		cs clientset.Interface
+		ns *v1.Namespace
+		// genericVolumeTestResource contains pv, pvc, sc, etc. of the first pod created
+		resource *genericVolumeTestResource
+
+		// All created PVCs, incl. the one in resource
+		pvcs []*v1.PersistentVolumeClaim
+
+		// All created PVs, incl. the one in resource
+		pvNames sets.String
+
+		runningPod       *v1.Pod
+		unschedulablePod *v1.Pod
+	}
+	var (
+		l local
+	)
+
+	// No preconditions to test. Normally they would be in a BeforeEach here.
+	f := framework.NewDefaultFramework("volumelimits")
+
+	// This checks that CSIMaxVolumeLimitChecker works as expected.
+	// A randomly chosen node should be able to handle as many CSI volumes as
+	// it claims to handle in CSINode.Spec.Drivers[x].Allocatable.
+	// The test uses one single pod with a lot of volumes to work around any
+	// max pod limit on a node.
+	// And one extra pod with a CSI volume should get Pending with a condition
+	// that says it's unschedulable because of volume limit.
+	// BEWARE: the test may create lot of volumes and it's really slow.
+	ginkgo.It("should support volume limits [Slow][Serial]", func() {
+		driverInfo := driver.GetDriverInfo()
+		if !driverInfo.Capabilities[CapVolumeLimits] {
+			ginkgo.Skip(fmt.Sprintf("driver %s does not support volume limits", driverInfo.Name))
+		}
+		var dDriver DynamicPVTestDriver
+		if dDriver = driver.(DynamicPVTestDriver); dDriver == nil {
+			framework.Failf("Test driver does not provide dynamically created volumes")
+		}
+
+		l.ns = f.Namespace
+		l.cs = f.ClientSet
+		l.config, l.testCleanup = driver.PrepareTest(f)
+		defer l.testCleanup()
+
+		ginkgo.By("Picking a random node")
+		var nodeName string
+		nodeList := framework.GetReadySchedulableNodesOrDie(f.ClientSet)
+		if len(nodeList.Items) != 0 {
+			nodeName = nodeList.Items[0].Name
+		} else {
+			framework.Failf("Unable to find ready and schedulable Node")
+		}
+		framework.Logf("Selected node %s", nodeName)
+
+		ginkgo.By("Checking node limits")
+		limit, err := getNodeLimits(l.cs, nodeName, driverInfo)
+		framework.ExpectNoError(err)
+
+		framework.Logf("Node %s can handle %d volumes of driver %s", nodeName, limit, driverInfo.Name)
+		// Create a storage class and generate a PVC. Do not instantiate the PVC yet, keep it for the last pod.
+		l.resource = createGenericVolumeTestResource(driver, l.config, pattern)
+		defer l.resource.cleanupResource()
+
+		defer func() {
+			cleanupTest(l.cs, l.ns.Name, l.runningPod.Name, l.unschedulablePod.Name, l.pvcs, l.pvNames)
+		}()
+
+		// Create <limit> PVCs for one gigantic pod.
+		ginkgo.By(fmt.Sprintf("Creating %d PVC(s)", limit))
+		for i := 0; i < limit; i++ {
+			pvc := framework.MakePersistentVolumeClaim(framework.PersistentVolumeClaimConfig{
+				ClaimSize:        dDriver.GetClaimSize(),
+				StorageClassName: &l.resource.sc.Name,
+			}, l.ns.Name)
+			pvc, err = l.cs.CoreV1().PersistentVolumeClaims(l.ns.Name).Create(pvc)
+			framework.ExpectNoError(err)
+			l.pvcs = append(l.pvcs, pvc)
+		}
+
+		ginkgo.By("Creating pod to use all PVC(s)")
+		pod := e2epod.MakeSecPod(l.ns.Name, l.pvcs, nil, false, "", false, false, framework.SELinuxLabel, nil)
+		// Use affinity to schedule everything on the right node
+		selection := e2epod.NodeSelection{}
+		e2epod.SetAffinity(&selection, nodeName)
+		pod.Spec.Affinity = selection.Affinity
+		l.runningPod, err = l.cs.CoreV1().Pods(l.ns.Name).Create(pod)
+		framework.ExpectNoError(err)
+
+		ginkgo.By("Waiting for all PVCs to get Bound")
+		l.pvNames, err = waitForAllPVCsPhase(l.cs, testSlowMultiplier*framework.PVBindingTimeout, l.pvcs)
+		framework.ExpectNoError(err)
+
+		ginkgo.By("Waiting for the pod Running")
+		err = e2epod.WaitTimeoutForPodRunningInNamespace(l.cs, l.runningPod.Name, l.ns.Name, testSlowMultiplier*framework.PodStartTimeout)
+		framework.ExpectNoError(err)
+
+		ginkgo.By("Creating an extra pod with one volume to exceed the limit")
+		pod = e2epod.MakeSecPod(l.ns.Name, []*v1.PersistentVolumeClaim{l.resource.pvc}, nil, false, "", false, false, framework.SELinuxLabel, nil)
+		// Use affinity to schedule everything on the right node
+		e2epod.SetAffinity(&selection, nodeName)
+		pod.Spec.Affinity = selection.Affinity
+		l.unschedulablePod, err = l.cs.CoreV1().Pods(l.ns.Name).Create(pod)
+
+		ginkgo.By("Waiting for the pod to get unschedulable with the right message")
+		err = e2epod.WaitForPodCondition(l.cs, l.ns.Name, l.unschedulablePod.Name, "Unschedulable", framework.PodStartTimeout, func(pod *v1.Pod) (bool, error) {
+			if pod.Status.Phase == v1.PodPending {
+				for _, cond := range pod.Status.Conditions {
+					matched, _ := regexp.MatchString("max.+volume.+count", cond.Message)
+					if cond.Type == v1.PodScheduled && cond.Status == v1.ConditionFalse && cond.Reason == "Unschedulable" && matched {
+						return true, nil
+					}
+				}
+			}
+			if pod.Status.Phase != v1.PodPending {
+				return true, fmt.Errorf("Expected pod to be in phase Pending, but got phase: %v", pod.Status.Phase)
+			}
+			return false, nil
+		})
+		framework.ExpectNoError(err)
+	})
+}
+
+func cleanupTest(cs clientset.Interface, ns string, runningPodName, unschedulablePodName string, pvcs []*v1.PersistentVolumeClaim, pvNames sets.String) error {
+	var cleanupErrors []string
+	if runningPodName != "" {
+		err := cs.CoreV1().Pods(ns).Delete(runningPodName, nil)
+		if err != nil {
+			cleanupErrors = append(cleanupErrors, fmt.Sprintf("failed to delete pod %s: %s", runningPodName, err))
+		}
+	}
+	if unschedulablePodName != "" {
+		err := cs.CoreV1().Pods(ns).Delete(unschedulablePodName, nil)
+		if err != nil {
+			cleanupErrors = append(cleanupErrors, fmt.Sprintf("failed to delete pod %s: %s", unschedulablePodName, err))
+		}
+	}
+	for _, pvc := range pvcs {
+		err := cs.CoreV1().PersistentVolumeClaims(ns).Delete(pvc.Name, nil)
+		if err != nil {
+			cleanupErrors = append(cleanupErrors, fmt.Sprintf("failed to delete PVC %s: %s", pvc.Name, err))
+		}
+	}
+	// Wait for the PVs to be deleted. It includes also pod and PVC deletion because of PVC protection.
+	// We use PVs to make sure that the test does not leave orphan PVs when a CSI driver is destroyed
+	// just after the test ends.
+	err := wait.Poll(5*time.Second, testSlowMultiplier*framework.PVDeletingTimeout, func() (bool, error) {
+		existing := 0
+		for _, pvName := range pvNames.UnsortedList() {
+			_, err := cs.CoreV1().PersistentVolumes().Get(pvName, metav1.GetOptions{})
+			if err == nil {
+				existing++
+			} else {
+				if errors.IsNotFound(err) {
+					pvNames.Delete(pvName)
+				} else {
+					framework.Logf("Failed to get PV %s: %s", pvName, err)
+				}
+			}
+		}
+		if existing > 0 {
+			framework.Logf("Waiting for %d PVs to be deleted", existing)
+			return false, nil
+		}
+		return true, nil
+	})
+	if err != nil {
+		cleanupErrors = append(cleanupErrors, fmt.Sprintf("timed out waiting for PVs to be deleted: %s", err))
+	}
+	if len(cleanupErrors) != 0 {
+		return fmt.Errorf("test cleanup failed: " + strings.Join(cleanupErrors, "; "))
+	}
+	return nil
+}
+
+func waitForAllPVCsPhase(cs clientset.Interface, timeout time.Duration, pvcs []*v1.PersistentVolumeClaim) (sets.String, error) {
+	pvNames := sets.NewString()
+	err := wait.Poll(5*time.Second, timeout, func() (bool, error) {
+		unbound := 0
+		for _, pvc := range pvcs {
+			pvc, err := cs.CoreV1().PersistentVolumeClaims(pvc.Namespace).Get(pvc.Name, metav1.GetOptions{})
+			if err != nil {
+				return false, err
+			}
+			if pvc.Status.Phase != v1.ClaimBound {
+				unbound++
+			} else {
+				pvNames.Insert(pvc.Spec.VolumeName)
+			}
+		}
+		if unbound > 0 {
+			framework.Logf("%d/%d of PVCs are Bound", pvNames.Len(), len(pvcs))
+			return false, nil
+		}
+		return true, nil
+	})
+	return pvNames, err
+}
+
+func getNodeLimits(cs clientset.Interface, nodeName string, driverInfo *DriverInfo) (int, error) {
+	if len(driverInfo.InTreePluginName) == 0 {
+		return getCSINodeLimits(cs, nodeName, driverInfo)
+	}
+	return getInTreeNodeLimits(cs, nodeName, driverInfo)
+}
+
+func getInTreeNodeLimits(cs clientset.Interface, nodeName string, driverInfo *DriverInfo) (int, error) {
+	node, err := cs.CoreV1().Nodes().Get(nodeName, metav1.GetOptions{})
+	if err != nil {
+		return 0, err
+	}
+
+	var allocatableKey string
+	switch driverInfo.InTreePluginName {
+	case migrationplugins.AWSEBSInTreePluginName:
+		allocatableKey = volumeutil.EBSVolumeLimitKey
+	case migrationplugins.GCEPDInTreePluginName:
+		allocatableKey = volumeutil.GCEVolumeLimitKey
+	case migrationplugins.CinderInTreePluginName:
+		allocatableKey = volumeutil.CinderVolumeLimitKey
+	case migrationplugins.AzureDiskInTreePluginName:
+		allocatableKey = volumeutil.AzureVolumeLimitKey
+	default:
+		return 0, fmt.Errorf("Unknown in-tree volume plugin name: %s", driverInfo.InTreePluginName)
+	}
+
+	limit, ok := node.Status.Allocatable[v1.ResourceName(allocatableKey)]
+	if !ok {
+		return 0, fmt.Errorf("Node %s does not contain status.allocatable[%s] for volume plugin %s", nodeName, allocatableKey, driverInfo.InTreePluginName)
+	}
+	return int(limit.Value()), nil
+}
+
+func getCSINodeLimits(cs clientset.Interface, nodeName string, driverInfo *DriverInfo) (int, error) {
+	// Wait in a loop, the driver might just have been installed and kubelet takes a while to publish everything.
+	var limit int
+	err := wait.PollImmediate(2*time.Second, csiNodeInfoTimeout, func() (bool, error) {
+		csiNode, err := cs.StorageV1beta1().CSINodes().Get(nodeName, metav1.GetOptions{})
+		if err != nil {
+			framework.Logf("%s", err)
+			return false, nil
+		}
+		var csiDriver *storagev1beta1.CSINodeDriver
+		for _, c := range csiNode.Spec.Drivers {
+			if c.Name == driverInfo.Name {
+				csiDriver = &c
+				break
+			}
+		}
+		if csiDriver == nil {
+			framework.Logf("CSINodeInfo does not have driver %s yet", driverInfo.Name)
+			return false, nil
+		}
+		if csiDriver.Allocatable == nil {
+			return false, fmt.Errorf("CSINodeInfo does not have Allocatable for driver %s", driverInfo.Name)
+		}
+		if csiDriver.Allocatable.Count == nil {
+			return false, fmt.Errorf("CSINodeInfo does not have Allocatable.Count for driver %s", driverInfo.Name)
+		}
+		limit = int(*csiDriver.Allocatable.Count)
+		return true, nil
+	})
+	return limit, err
+}