fix some missing errors return statements

Signed-off-by: haoshuwei <haoshuwei24@gmail.com>
This commit is contained in:
haoshuwei 2019-09-09 13:54:14 +08:00
parent 1cdd0848ee
commit c4fe8f11b2
3 changed files with 9 additions and 0 deletions

View File

@ -90,6 +90,9 @@ func (s *DryRunnableStorage) GuaranteedUpdate(
return err return err
} }
rev, err := s.Versioner().ObjectResourceVersion(ptrToType) rev, err := s.Versioner().ObjectResourceVersion(ptrToType)
if err != nil {
return err
}
out, _, err := tryUpdate(ptrToType, storage.ResponseMeta{ResourceVersion: rev}) out, _, err := tryUpdate(ptrToType, storage.ResponseMeta{ResourceVersion: rev})
if err != nil { if err != nil {
return err return err

View File

@ -251,6 +251,9 @@ func (o *ApplyOptions) Complete(f cmdutil.Factory, cmd *cobra.Command) error {
o.OpenAPISchema, _ = f.OpenAPISchema() o.OpenAPISchema, _ = f.OpenAPISchema()
o.Validator, err = f.Validator(cmdutil.GetFlagBool(cmd, "validate")) o.Validator, err = f.Validator(cmdutil.GetFlagBool(cmd, "validate"))
if err != nil {
return err
}
o.Builder = f.NewBuilder() o.Builder = f.NewBuilder()
o.Mapper, err = f.ToRESTMapper() o.Mapper, err = f.ToRESTMapper()
if err != nil { if err != nil {

View File

@ -182,6 +182,9 @@ func (o *LabelOptions) Complete(f cmdutil.Factory, cmd *cobra.Command, args []st
} }
o.resources = resources o.resources = resources
o.newLabels, o.removeLabels, err = parseLabels(labelArgs) o.newLabels, o.removeLabels, err = parseLabels(labelArgs)
if err != nil {
return err
}
if o.list && len(o.outputFormat) > 0 { if o.list && len(o.outputFormat) > 0 {
return fmt.Errorf("--list and --output may not be specified together") return fmt.Errorf("--list and --output may not be specified together")