Changes to buckets and comments

This commit is contained in:
Chinmay Chapla 2023-05-31 19:23:57 +00:00
parent 6426962059
commit c539c73916
2 changed files with 1 additions and 3 deletions

View File

@ -125,7 +125,7 @@ func newWebhookConversionMetrics() *WebhookConversionMetrics {
Namespace: namespace,
Help: "Webhook conversion request latency",
// Various buckets from 5 ms to 60 seconds
Buckets: []float64{0.005, 0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 15, 20, 25, 30, 45, 60},
Buckets: []float64{0.005, 0.01, 0.02, 0.05, 0.1, 0.2, 0.5, 1, 2, 5, 10, 20, 30, 45, 60},
StabilityLevel: metrics.ALPHA,
},
[]string{"result", "failure_type"},

View File

@ -41,7 +41,6 @@ func TestWebhookConversionMetrics_ObserveWebhookConversionSuccess(t *testing.T)
wantLabels map[string]string
expectedRequestValue int
}{
// TODO: Add test cases.
{
name: "test_conversion_success",
fields: fields{
@ -102,7 +101,6 @@ func TestWebhookConversionMetrics_ObserveWebhookConversionFailure(t *testing.T)
expectedRequestValue int
expectedLatencyCount int
}{
// TODO: Add test cases.
{
name: "test_conversion_failure",
fields: fields{