From deb1bb8bfff012e03ccc80fd85ee4fc2f9fceb6d Mon Sep 17 00:00:00 2001 From: Andrew Sy Kim Date: Mon, 28 Sep 2020 09:29:06 -0400 Subject: [PATCH] fake dynamic client: document that List does not preserve TypeMeta in UnstructuredList Signed-off-by: Andrew Sy Kim --- staging/src/k8s.io/client-go/dynamic/fake/simple.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/staging/src/k8s.io/client-go/dynamic/fake/simple.go b/staging/src/k8s.io/client-go/dynamic/fake/simple.go index ec2042550ab..001780970bb 100644 --- a/staging/src/k8s.io/client-go/dynamic/fake/simple.go +++ b/staging/src/k8s.io/client-go/dynamic/fake/simple.go @@ -35,7 +35,9 @@ import ( func NewSimpleDynamicClient(scheme *runtime.Scheme, objects ...runtime.Object) *FakeDynamicClient { // In order to use List with this client, you have to have the v1.List registered in your scheme. Neat thing though - // it does NOT have to be the *same* list + // it does NOT have to be the *same* list. UnstructuredList returned from this fake client will NOT have apiVersion and kind set, + // but each Unstructured object in Items will preserve their respective apiVersion and kind. As a result, schema conversion for + // *List kinds will not work and conversion of each Unstructured object in Items will be required instead. scheme.AddKnownTypeWithName(schema.GroupVersionKind{Group: "fake-dynamic-client-group", Version: "v1", Kind: "List"}, &unstructured.UnstructuredList{}) codecs := serializer.NewCodecFactory(scheme)