From c65ac62cdd9352842cbef9066922e095ba9bbc01 Mon Sep 17 00:00:00 2001
From: Yuki Yugui Sonoda <yugui@google.com>
Date: Thu, 31 Jul 2014 14:38:54 +0900
Subject: [PATCH] Allow omitting -machines flag in apiserver when
 -cloud_provider and -minion_regexp are specified because it is eventually
 overwritten by -minion_regexp.

---
 cmd/apiserver/apiserver.go | 17 +++++++++++++----
 1 file changed, 13 insertions(+), 4 deletions(-)

diff --git a/cmd/apiserver/apiserver.go b/cmd/apiserver/apiserver.go
index c3fef07d796..ac57bc0b9a5 100644
--- a/cmd/apiserver/apiserver.go
+++ b/cmd/apiserver/apiserver.go
@@ -50,16 +50,25 @@ func init() {
 	flag.Var(&machineList, "machines", "List of machines to schedule onto, comma separated.")
 }
 
+func verifyMinionFlags() {
+	if *cloudProvider == "" || *minionRegexp == "" {
+		if len(machineList) == 0 {
+			glog.Fatal("No machines specified!")
+		}
+		return
+	}
+	if len(machineList) != 0 {
+		glog.Info("-machines is overwritten by -minion_regexp")
+	}
+}
+
 func main() {
 	flag.Parse()
 	util.InitLogs()
 	defer util.FlushLogs()
 
 	version.PrintAndExitIfRequested()
-
-	if len(machineList) == 0 {
-		glog.Fatal("No machines specified!")
-	}
+	verifyMinionFlags()
 
 	var cloud cloudprovider.Interface
 	switch *cloudProvider {