From 7e9dfad2b68de146e0f1f1f421a3be694985c412 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Wed, 30 Nov 2022 14:37:53 +0800 Subject: [PATCH 1/2] sort unwanted dependencies in order --- hack/unwanted-dependencies.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hack/unwanted-dependencies.json b/hack/unwanted-dependencies.json index 35c06427938..75d121c1f27 100644 --- a/hack/unwanted-dependencies.json +++ b/hack/unwanted-dependencies.json @@ -18,13 +18,13 @@ "github.com/influxdata/influxdb1-client": "", "github.com/json-iterator/go": "refer to #105030", "github.com/miekg/dns": "no dns client/server should be required", + "github.com/mndrix/tap-go": "unmaintained", "github.com/onsi/ginkgo": "Ginkgo has been migrated to V2, refer to #109111", "github.com/spf13/viper": "refer to #102598", + "github.com/xeipuuv/gojsonschema": "unmaintained", "go.mongodb.org/mongo-driver": "", "gopkg.in/fsnotify.v1": "obsolete, use github.com/fsnotify/fsnotify", "k8s.io/klog": "we have switched to klog v2, so avoid klog v1", - "github.com/mndrix/tap-go": "unmaintained", - "github.com/xeipuuv/gojsonschema": "unmaintained", "rsc.io/quote": "refer to #102833", "rsc.io/sampler": "refer to #102833" } From a782bd62bd1640dbee531c526c46fa92f27c8878 Mon Sep 17 00:00:00 2001 From: Paco Xu Date: Wed, 30 Nov 2022 15:11:57 +0800 Subject: [PATCH 2/2] add github.com/mindprince/gonvml to unwanted dependencies for license reason --- hack/unwanted-dependencies.json | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/hack/unwanted-dependencies.json b/hack/unwanted-dependencies.json index 75d121c1f27..0aec8440926 100644 --- a/hack/unwanted-dependencies.json +++ b/hack/unwanted-dependencies.json @@ -18,6 +18,7 @@ "github.com/influxdata/influxdb1-client": "", "github.com/json-iterator/go": "refer to #105030", "github.com/miekg/dns": "no dns client/server should be required", + "github.com/mindprince/gonvml": "depends on nvml.h that does not appear to permit modification, redistribution", "github.com/mndrix/tap-go": "unmaintained", "github.com/onsi/ginkgo": "Ginkgo has been migrated to V2, refer to #109111", "github.com/spf13/viper": "refer to #102598", @@ -56,6 +57,9 @@ "go.opentelemetry.io/contrib/instrumentation/github.com/emicklei/go-restful/otelrestful", "k8s.io/kube-openapi", "sigs.k8s.io/structured-merge-diff/v4" + ], + "github.com/mindprince/gonvml": [ + "github.com/google/cadvisor" ] } }