From c6f9b402fb64dd2363d45a5493bd997fa00102e2 Mon Sep 17 00:00:00 2001 From: knight42 Date: Sat, 5 Sep 2020 13:36:20 +0800 Subject: [PATCH] test(kuberuntime): deflake TestRecordOperation Avoid using hard-coded port Signed-off-by: knight42 --- pkg/kubelet/kuberuntime/instrumented_services_test.go | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/pkg/kubelet/kuberuntime/instrumented_services_test.go b/pkg/kubelet/kuberuntime/instrumented_services_test.go index 91a1e5be23d..d027414b650 100644 --- a/pkg/kubelet/kuberuntime/instrumented_services_test.go +++ b/pkg/kubelet/kuberuntime/instrumented_services_test.go @@ -34,17 +34,16 @@ func TestRecordOperation(t *testing.T) { legacyregistry.MustRegister(metrics.RuntimeOperationsDuration) legacyregistry.MustRegister(metrics.RuntimeOperationsErrors) - temporalServer := "127.0.0.1:1234" - l, err := net.Listen("tcp", temporalServer) + l, err := net.Listen("tcp", "127.0.0.1:0") assert.NoError(t, err) defer l.Close() - prometheusURL := "http://" + temporalServer + "/metrics" + prometheusURL := "http://" + l.Addr().String() + "/metrics" mux := http.NewServeMux() //lint:ignore SA1019 ignore deprecated warning until we move off of global registries mux.Handle("/metrics", legacyregistry.Handler()) server := &http.Server{ - Addr: temporalServer, + Addr: l.Addr().String(), Handler: mux, } go func() {