github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 17:30:00 +00:00
Code Issues Projects Releases Wiki Activity

using case name instead

Browse Source
This commit is contained in:
wccsama 2020-04-30 13:55:50 +08:00
parent 7d45e12523
commit c776e80109
1 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
pkg/controller/podgc/gc_controller_test.go
View File

@ -18,7 +18,6 @@ package podgc
import ( import (
"context" "context"
"fmt"
"sync" "sync"
"testing" "testing"
"time" "time"
@ -68,12 +67,13 @@ func TestGCTerminated(t *testing.T) {
} }
testCases := []struct { testCases := []struct {
name string
pods []nameToPhase pods []nameToPhase
threshold int threshold int
deletedPodNames sets.String deletedPodNames sets.String
}{ }{
{ {
// case 1 name: "threshold = 0, disables terminated pod deletion",
pods: []nameToPhase{ pods: []nameToPhase{
{name: "a", phase: v1.PodFailed}, {name: "a", phase: v1.PodFailed},
{name: "b", phase: v1.PodSucceeded}, {name: "b", phase: v1.PodSucceeded},
@ -83,7 +83,7 @@ func TestGCTerminated(t *testing.T) {
deletedPodNames: sets.NewString(), deletedPodNames: sets.NewString(),
}, },
{ {
// case 2 name: "threshold = 1, delete pod a which is PodFailed and pod b which is PodSucceeded",
pods: []nameToPhase{ pods: []nameToPhase{
{name: "a", phase: v1.PodFailed}, {name: "a", phase: v1.PodFailed},
{name: "b", phase: v1.PodSucceeded}, {name: "b", phase: v1.PodSucceeded},
@ -93,7 +93,7 @@ func TestGCTerminated(t *testing.T) {
deletedPodNames: sets.NewString("a", "b"), deletedPodNames: sets.NewString("a", "b"),
}, },
{ {
// case 3 name: "threshold = 1, delete pod b which is PodSucceeded",
pods: []nameToPhase{ pods: []nameToPhase{
{name: "a", phase: v1.PodRunning}, {name: "a", phase: v1.PodRunning},
{name: "b", phase: v1.PodSucceeded}, {name: "b", phase: v1.PodSucceeded},
@ -103,7 +103,7 @@ func TestGCTerminated(t *testing.T) {
deletedPodNames: sets.NewString("b"), deletedPodNames: sets.NewString("b"),
}, },
{ {
// case 4 name: "threshold = 1, delete pod a which is PodFailed",
pods: []nameToPhase{ pods: []nameToPhase{
{name: "a", phase: v1.PodFailed}, {name: "a", phase: v1.PodFailed},
{name: "b", phase: v1.PodSucceeded}, {name: "b", phase: v1.PodSucceeded},
@ -112,7 +112,7 @@ func TestGCTerminated(t *testing.T) {
deletedPodNames: sets.NewString("a"), deletedPodNames: sets.NewString("a"),
}, },
{ {
// case 5 name: "threshold = 5, don't delete pod",
pods: []nameToPhase{ pods: []nameToPhase{
{name: "a", phase: v1.PodFailed}, {name: "a", phase: v1.PodFailed},
{name: "b", phase: v1.PodSucceeded}, {name: "b", phase: v1.PodSucceeded},
@ -123,7 +123,7 @@ func TestGCTerminated(t *testing.T) {
} }
for i, test := range testCases { for i, test := range testCases {
t.Run(fmt.Sprintf("case: %v", i), func(t *testing.T) { t.Run(test.name, func(t *testing.T) {
client := fake.NewSimpleClientset(&v1.NodeList{Items: []v1.Node{*testutil.NewNode("node")}}) client := fake.NewSimpleClientset(&v1.NodeList{Items: []v1.Node{*testutil.NewNode("node")}})
gcc, podInformer, _ := NewFromClient(client, test.threshold) gcc, podInformer, _ := NewFromClient(client, test.threshold)
deletedPodNames := make([]string, 0) deletedPodNames := make([]string, 0)