From c7a25a3786dbc39c1ff34aedead40e61105e0ee4 Mon Sep 17 00:00:00 2001 From: Anirudh Date: Tue, 18 Jul 2017 15:03:57 -0700 Subject: [PATCH] DS: Api Machinery Fixes --- pkg/api/defaulting_test.go | 2 ++ pkg/apis/apps/v1beta2/conversion.go | 4 ++-- .../rbac/bootstrappolicy/testdata/controller-roles.yaml | 2 ++ staging/src/k8s.io/api/apps/v1beta2/types.go | 2 +- 4 files changed, 7 insertions(+), 3 deletions(-) diff --git a/pkg/api/defaulting_test.go b/pkg/api/defaulting_test.go index 35fa65a15d6..6f9f14730db 100644 --- a/pkg/api/defaulting_test.go +++ b/pkg/api/defaulting_test.go @@ -108,6 +108,8 @@ func TestDefaulting(t *testing.T) { // {Group: "kubeadm.k8s.io", Version: "v1alpha1", Kind: "NodeConfiguration"}: {}, {Group: "extensions", Version: "v1beta1", Kind: "DaemonSet"}: {}, {Group: "extensions", Version: "v1beta1", Kind: "DaemonSetList"}: {}, + {Group: "apps", Version: "v1beta2", Kind: "DaemonSet"}: {}, + {Group: "apps", Version: "v1beta2", Kind: "DaemonSetList"}: {}, {Group: "extensions", Version: "v1beta1", Kind: "Deployment"}: {}, {Group: "extensions", Version: "v1beta1", Kind: "DeploymentList"}: {}, {Group: "apps", Version: "v1beta1", Kind: "Deployment"}: {}, diff --git a/pkg/apis/apps/v1beta2/conversion.go b/pkg/apis/apps/v1beta2/conversion.go index 151b19d60a4..a41cd39f8a9 100644 --- a/pkg/apis/apps/v1beta2/conversion.go +++ b/pkg/apis/apps/v1beta2/conversion.go @@ -88,7 +88,7 @@ func addConversionFuncs(scheme *runtime.Scheme) error { return nil } -func Convert_apps_RollingUpdateDaemonSet_To_v1beta2_RollingUpdateDaemonSet(in *apps.RollingUpdateDaemonSet, out *appsv1beta2.RollingUpdateDaemonSet, s conversion.Scope) error { +func Convert_extensions_RollingUpdateDaemonSet_To_v1beta2_RollingUpdateDaemonSet(in *extensions.RollingUpdateDaemonSet, out *appsv1beta2.RollingUpdateDaemonSet, s conversion.Scope) error { if out.MaxUnavailable == nil { out.MaxUnavailable = &intstr.IntOrString{} } @@ -98,7 +98,7 @@ func Convert_apps_RollingUpdateDaemonSet_To_v1beta2_RollingUpdateDaemonSet(in *a return nil } -func Convert_v1beta2_RollingUpdateDaemonSet_To_apps_RollingUpdateDaemonSet(in *appsv1beta2.RollingUpdateDaemonSet, out *apps.RollingUpdateDaemonSet, s conversion.Scope) error { +func Convert_v1beta2_RollingUpdateDaemonSet_To_extensions_RollingUpdateDaemonSet(in *appsv1beta2.RollingUpdateDaemonSet, out *extensions.RollingUpdateDaemonSet, s conversion.Scope) error { if err := s.Convert(in.MaxUnavailable, &out.MaxUnavailable, 0); err != nil { return err } diff --git a/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml b/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml index 4f97e5416b4..b85d951cd6a 100644 --- a/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml +++ b/plugin/pkg/auth/authorizer/rbac/bootstrappolicy/testdata/controller-roles.yaml @@ -150,6 +150,7 @@ items: name: system:controller:daemon-set-controller rules: - apiGroups: + - apps - extensions resources: - daemonsets @@ -158,6 +159,7 @@ items: - list - watch - apiGroups: + - apps - extensions resources: - daemonsets/status diff --git a/staging/src/k8s.io/api/apps/v1beta2/types.go b/staging/src/k8s.io/api/apps/v1beta2/types.go index 858d3ec08e4..5a018c62485 100644 --- a/staging/src/k8s.io/api/apps/v1beta2/types.go +++ b/staging/src/k8s.io/api/apps/v1beta2/types.go @@ -641,7 +641,7 @@ type DaemonSetStatus struct { CollisionCount *int64 `json:"collisionCount,omitempty" protobuf:"varint,9,opt,name=collisionCount"` } -// +genclient=true +// +genclient // +k8s:deepcopy-gen:interfaces=k8s.io/apimachinery/pkg/runtime.Object // WIP: This is not ready to be used and we plan to make breaking changes to it.