From c8045049f3b5ea72076a06535cf9fe11850d5d19 Mon Sep 17 00:00:00 2001 From: Marek Counts Date: Fri, 7 Jun 2019 08:36:49 -0400 Subject: [PATCH] updated tests to prevent false positive one test also proved it did not call the internet but this was not fool proof as it did not return a string and thus could be called with something expecting to fail. --- cmd/kubeadm/app/util/version_test.go | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/cmd/kubeadm/app/util/version_test.go b/cmd/kubeadm/app/util/version_test.go index 39de4bd1e45..e056f2d26d4 100644 --- a/cmd/kubeadm/app/util/version_test.go +++ b/cmd/kubeadm/app/util/version_test.go @@ -52,7 +52,7 @@ func TestValidVersion(t *testing.T) { for _, s := range validVersions { t.Run(s, func(t *testing.T) { fileFetcher := func(url string, timeout time.Duration) (string, error) { - return "", errors.New("Should not make internet call") + return "", errors.New("should not make internet call") } ver, err := kubernetesReleaseVersion(s, fileFetcher) t.Log("Valid: ", s, ver, err) @@ -77,7 +77,7 @@ func TestInvalidVersion(t *testing.T) { for _, s := range invalidVersions { t.Run(s, func(t *testing.T) { fileFetcher := func(url string, timeout time.Duration) (string, error) { - return "", errors.New("Should not make internet call") + return "should not make internet calls", errors.New("should not make internet call") } ver, err := kubernetesReleaseVersion(s, fileFetcher) t.Log("Invalid: ", s, ver, err) @@ -100,7 +100,7 @@ func TestValidConvenientForUserVersion(t *testing.T) { for _, s := range validVersions { t.Run(s, func(t *testing.T) { fileFetcher := func(url string, timeout time.Duration) (string, error) { - return "", errors.New("Should not make internet call") + return "", errors.New("should not make internet call") } ver, err := kubernetesReleaseVersion(s, fileFetcher) t.Log("Valid: ", s, ver, err)