From c84b5b0a99feb8832638c4e3d04f1dbc8159cec3 Mon Sep 17 00:00:00 2001 From: Aldo Culquicondor Date: Mon, 19 Jun 2023 13:27:17 -0400 Subject: [PATCH] Cleanup unnecessary renames of variable t Change-Id: Idf4d0ed7e09cf14323567381de158041236680b0 --- test/integration/daemonset/daemonset_test.go | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/test/integration/daemonset/daemonset_test.go b/test/integration/daemonset/daemonset_test.go index 566495040a7..4c22d1cc525 100644 --- a/test/integration/daemonset/daemonset_test.go +++ b/test/integration/daemonset/daemonset_test.go @@ -466,8 +466,9 @@ func updateDS(t *testing.T, dsClient appstyped.DaemonSetInterface, dsName string func forEachStrategy(t *testing.T, tf func(t *testing.T, strategy *apps.DaemonSetUpdateStrategy)) { for _, strategy := range updateStrategies() { - t.Run(fmt.Sprintf("%s_%s", t.Name(), strategy.Type), - func(tt *testing.T) { tf(tt, strategy) }) + t.Run(string(strategy.Type), func(t *testing.T) { + tf(t, strategy) + }) } } @@ -536,8 +537,8 @@ func TestSimpleDaemonSetLaunchesPods(t *testing.T) { func TestSimpleDaemonSetRestartsPodsOnTerminalPhase(t *testing.T) { for _, podPhase := range []v1.PodPhase{v1.PodSucceeded, v1.PodFailed} { - t.Run(string(podPhase), func(tt *testing.T) { - forEachStrategy(tt, func(t *testing.T, strategy *apps.DaemonSetUpdateStrategy) { + t.Run(string(podPhase), func(t *testing.T) { + forEachStrategy(t, func(t *testing.T, strategy *apps.DaemonSetUpdateStrategy) { ctx, closeFn, dc, informers, clientset := setup(t) defer closeFn() ns := framework.CreateNamespaceOrDie(clientset, "daemonset-restart-terminal-pod-test", t)