From eeae981048e5094c4f1d59f764173c62008b85b4 Mon Sep 17 00:00:00 2001 From: Peter Hunt Date: Thu, 25 Jul 2024 10:00:33 -0400 Subject: [PATCH] set LocalStorageCapacityIsolationFSQuotaMonitoring to false by default as the feature relies on UserNamespaces support, which is also off by default. Having it on by default won't do anything negative, except adding some needless checks as to whether the pod has hostUsers==true (impossible without the feature gate) Signed-off-by: Peter Hunt --- pkg/features/kube_features.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/features/kube_features.go b/pkg/features/kube_features.go index ad5d514b0de..a21fdcf5244 100644 --- a/pkg/features/kube_features.go +++ b/pkg/features/kube_features.go @@ -429,9 +429,11 @@ const ( // owner: @RobertKrawitz // alpha: v1.15 + // beta: v1.31 // // Allow use of filesystems for ephemeral storage monitoring. // Only applies if LocalStorageCapacityIsolation is set. + // Relies on UserNamespacesSupport feature, and thus should follow it when setting defaults. LocalStorageCapacityIsolationFSQuotaMonitoring featuregate.Feature = "LocalStorageCapacityIsolationFSQuotaMonitoring" // owner: @damemi @@ -1099,7 +1101,7 @@ var defaultKubernetesFeatureGates = map[featuregate.Feature]featuregate.FeatureS LegacyServiceAccountTokenCleanUp: {Default: true, PreRelease: featuregate.GA, LockToDefault: true}, // GA in 1.30; remove in 1.32 - LocalStorageCapacityIsolationFSQuotaMonitoring: {Default: true, PreRelease: featuregate.Beta}, + LocalStorageCapacityIsolationFSQuotaMonitoring: {Default: false, PreRelease: featuregate.Beta}, LogarithmicScaleDown: {Default: true, PreRelease: featuregate.GA, LockToDefault: true},