github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-02 16:29:21 +00:00
Code Issues Projects Releases Wiki Activity

fix bug where string slice flag is not assigned

Browse Source
This commit is contained in:
zhiming 2021-06-05 20:33:17 +08:00
parent 8eff96dd12
commit c9414c2bba
2 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
staging/src/k8s.io/component-base/cli/flag/string_slice_flag.go
View File

@ -46,8 +46,7 @@ func (s *StringSlice) String() string {
func (s *StringSlice) Set(val string) error { func (s *StringSlice) Set(val string) error {
if s.value == nil || !s.changed { if s.value == nil || !s.changed {
v := make([]string, 0) *s.value = make([]string, 0)
s.value = &v
} }
*s.value = append(*s.value, val) *s.value = append(*s.value, val)
s.changed = true s.changed = true

4
staging/src/k8s.io/component-base/cli/flag/string_slice_flag_test.go
View File

@ -83,8 +83,8 @@ func TestStringSlice(t *testing.T) {
} else if err != nil { } else if err != nil {
t.Errorf("%d: expected nil error, got %v", i, err) t.Errorf("%d: expected nil error, got %v", i, err)
} }
if !reflect.DeepEqual(*v.value, test.expected) { if !reflect.DeepEqual(s, test.expected) {
t.Errorf("%d: expected %+v, got %+v", i, test.expected, *v.value) t.Errorf("%d: expected %+v, got %+v", i, test.expected, s)
} }
if v.changed != test.changed { if v.changed != test.changed {
t.Errorf("%d: expected %t got %t", i, test.changed, v.changed) t.Errorf("%d: expected %t got %t", i, test.changed, v.changed)