From c9944709bce8ee8254c34ef48959e81f50140dea Mon Sep 17 00:00:00 2001 From: Damien Grisonnet Date: Wed, 1 Feb 2023 15:10:33 +0100 Subject: [PATCH] restclient: rename "method" label to "verb" Verb is the commonly used label when referring to HTTP verbs. rest_client_requests_total is the only metric in the rest package using `method` instead of `verb` which makes it inconsistent and confusing. Signed-off-by: Damien Grisonnet --- .../component-base/metrics/prometheus/restclient/metrics.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go b/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go index 50a74db9f34..92abee81fd7 100644 --- a/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go +++ b/staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go @@ -77,9 +77,9 @@ var ( &k8smetrics.CounterOpts{ Name: "rest_client_requests_total", StabilityLevel: k8smetrics.ALPHA, - Help: "Number of HTTP requests, partitioned by status code, method, and host.", + Help: "Number of HTTP requests, partitioned by status code, verb, and host.", }, - []string{"code", "method", "host"}, + []string{"code", "verb", "host"}, ) execPluginCertTTLAdapter = &expiryToTTLAdapter{}