From 084c52551baa3dbf0aa47f193b3abddeb8e4d673 Mon Sep 17 00:00:00 2001 From: Joe Betz Date: Fri, 31 May 2019 16:17:24 -0700 Subject: [PATCH] Fix admission metrics to use bucket sizes matching metric unit --- staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go b/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go index 04eb7b522ab..56cc07edd39 100644 --- a/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go +++ b/staging/src/k8s.io/apiserver/pkg/admission/metrics/metrics.go @@ -32,8 +32,8 @@ const ( ) var ( - // Use buckets ranging from 25 ms to ~2.5 seconds. - latencyBuckets = prometheus.ExponentialBuckets(25000, 2.5, 5) + // Use buckets ranging from 5 ms to 2.5 seconds (admission webhooks timeout at 30 seconds by default). + latencyBuckets = []float64{0.005, 0.025, 0.1, 0.5, 2.5} latencySummaryMaxAge = 5 * time.Hour // Metrics provides access to all admission metrics.