From 19c9860bb3786a10516217a048b2279e80a934e4 Mon Sep 17 00:00:00 2001 From: NickrenREN Date: Thu, 24 Nov 2016 19:06:17 +0800 Subject: [PATCH] fix if condition question in kubelet run() function here variable err returned by function NewForConfig(&eventClientConfig) if CreateAPIServerClientConfig() function is executed correctly. We should use else instead of if. Or put block (if err != nil) to block (if err == nil) above --- cmd/kubelet/app/server.go | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/cmd/kubelet/app/server.go b/cmd/kubelet/app/server.go index df98b4bb871..f498757ad10 100644 --- a/cmd/kubelet/app/server.go +++ b/cmd/kubelet/app/server.go @@ -392,8 +392,7 @@ func run(s *options.KubeletServer, kubeDeps *kubelet.KubeletDeps) (err error) { eventClientConfig.QPS = float32(s.EventRecordQPS) eventClientConfig.Burst = int(s.EventBurst) eventClient, err = clientset.NewForConfig(&eventClientConfig) - } - if err != nil { + } else { if s.RequireKubeConfig { return fmt.Errorf("invalid kubeconfig: %v", err) }