github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-09-23 02:47:57 +00:00
Code Issues Projects Releases Wiki Activity

remove TODO in test/e2e/framework/providers/gce/ingress.go

Browse Source 
Signed-off-by: yuxiaobo <yuxiaobogo@163.com>
This commit is contained in:
yuxiaobo
2020-01-13 16:11:03 +08:00
parent 36e40fb850
commit cb07680ee9
2 changed files with 2 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
test/e2e/framework/providers/gce/ingress.go
View File

@@ -571,19 +571,8 @@ func (cont *IngressController) GetFirewallRuleName() string {
}
// GetFirewallRule returns the firewall used by the IngressController.
// Causes a fatal error incase of an error.
// TODO: Rename this to GetFirewallRuleOrDie and similarly rename all other
// methods here to be consistent with rest of the code in this repo.
func (cont *IngressController) GetFirewallRule() *compute.Firewall {
fw, err := cont.GetFirewallRuleOrError()
framework.ExpectNoError(err)
return fw
}
// GetFirewallRuleOrError returns the firewall used by the IngressController.
// Returns an error if that fails.
// TODO: Rename this to GetFirewallRule when the above method with that name is renamed.
func (cont *IngressController) GetFirewallRuleOrError() (*compute.Firewall, error) {
func (cont *IngressController) GetFirewallRule() (*compute.Firewall, error) {
gceCloud := cont.Cloud.Provider.(*Provider).gceCloud
fwName := cont.GetFirewallRuleName()
return gceCloud.GetFirewall(fwName)