refactor: Simplify the code logic.

This commit is contained in:
zhifei92 2024-12-03 20:31:09 +08:00
parent 810e9e212e
commit cb74323e07
2 changed files with 4 additions and 4 deletions

View File

@ -801,7 +801,7 @@ func WaitForPodScheduled(ctx context.Context, c clientset.Interface, namespace,
func WaitForPodContainerStarted(ctx context.Context, c clientset.Interface, namespace, podName string, containerIndex int, timeout time.Duration) error {
conditionDesc := fmt.Sprintf("container %d started", containerIndex)
return WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
if containerIndex > len(pod.Status.ContainerStatuses)-1 {
if containerIndex >= len(pod.Status.ContainerStatuses) {
return false, nil
}
containerStatus := pod.Status.ContainerStatuses[containerIndex]
@ -813,7 +813,7 @@ func WaitForPodContainerStarted(ctx context.Context, c clientset.Interface, name
func WaitForPodInitContainerStarted(ctx context.Context, c clientset.Interface, namespace, podName string, initContainerIndex int, timeout time.Duration) error {
conditionDesc := fmt.Sprintf("init container %d started", initContainerIndex)
return WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
if initContainerIndex > len(pod.Status.InitContainerStatuses)-1 {
if initContainerIndex >= len(pod.Status.InitContainerStatuses) {
return false, nil
}
initContainerStatus := pod.Status.InitContainerStatuses[initContainerIndex]

View File

@ -577,7 +577,7 @@ func getPidFromPidFile(pidFile string) (int, error) {
func WaitForPodInitContainerRestartCount(ctx context.Context, c clientset.Interface, namespace, podName string, initContainerIndex int, desiredRestartCount int32, timeout time.Duration) error {
conditionDesc := fmt.Sprintf("init container %d started", initContainerIndex)
return e2epod.WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
if initContainerIndex > len(pod.Status.InitContainerStatuses)-1 {
if initContainerIndex >= len(pod.Status.InitContainerStatuses) {
return false, nil
}
containerStatus := pod.Status.InitContainerStatuses[initContainerIndex]
@ -590,7 +590,7 @@ func WaitForPodInitContainerRestartCount(ctx context.Context, c clientset.Interf
func WaitForPodContainerRestartCount(ctx context.Context, c clientset.Interface, namespace, podName string, containerIndex int, desiredRestartCount int32, timeout time.Duration) error {
conditionDesc := fmt.Sprintf("container %d started", containerIndex)
return e2epod.WaitForPodCondition(ctx, c, namespace, podName, conditionDesc, timeout, func(pod *v1.Pod) (bool, error) {
if containerIndex > len(pod.Status.ContainerStatuses)-1 {
if containerIndex >= len(pod.Status.ContainerStatuses) {
return false, nil
}
containerStatus := pod.Status.ContainerStatuses[containerIndex]