github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-08-03 17:30:00 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #81577 from logicalhan/lazy-init

Browse Source 
lock the mutation of the create boolean for safety
This commit is contained in:
Kubernetes Prow Robot 2019-08-19 02:53:44 -07:00 committed by GitHub
commit cb7c98e59f
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
staging/src/k8s.io/component-base/metrics/metric.go
View File

@ -64,12 +64,15 @@ type lazyMetric struct {
isDeprecated bool isDeprecated bool
isHidden bool isHidden bool
isCreated bool isCreated bool
createLock sync.RWMutex
markDeprecationOnce sync.Once markDeprecationOnce sync.Once
createOnce sync.Once createOnce sync.Once
self kubeCollector self kubeCollector
} }
func (r *lazyMetric) IsCreated() bool { func (r *lazyMetric) IsCreated() bool {
r.createLock.RLock()
defer r.createLock.RUnlock()
return r.isCreated return r.isCreated
} }
@ -125,6 +128,8 @@ func (r *lazyMetric) Create(version *semver.Version) bool {
return false return false
} }
r.createOnce.Do(func() { r.createOnce.Do(func() {
r.createLock.Lock()
defer r.createLock.Unlock()
r.isCreated = true r.isCreated = true
if r.IsDeprecated() { if r.IsDeprecated() {
r.self.initializeDeprecatedMetric() r.self.initializeDeprecatedMetric()