From cba5e84fd1a9a6ce14a60ab46b1ba87f3aa221f3 Mon Sep 17 00:00:00 2001 From: CJ Cullen Date: Tue, 19 Apr 2016 10:42:58 -0700 Subject: [PATCH] Fix goroutine leak in ssh-tunnel healthcheck. --- pkg/ssh/ssh.go | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/pkg/ssh/ssh.go b/pkg/ssh/ssh.go index 44541574737..b3e1b032cc2 100644 --- a/pkg/ssh/ssh.go +++ b/pkg/ssh/ssh.go @@ -362,8 +362,12 @@ func (l *SSHTunnelList) healthCheck(e sshTunnelEntry) error { TLSClientConfig: &tls.Config{InsecureSkipVerify: true}, }) client := &http.Client{Transport: transport} - _, err := client.Get(l.healthCheckURL.String()) - return err + resp, err := client.Get(l.healthCheckURL.String()) + if err != nil { + return err + } + resp.Body.Close() + return nil } func (l *SSHTunnelList) removeAndReAdd(e sshTunnelEntry) {