github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

Fix golint issues in pkg/kubelet/secret

Browse Source
This commit is contained in:
obitech 2019-05-25 22:35:35 +02:00
parent b767b1b250
commit cbdfccc9f8
4 changed files with 24 additions and 13 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
hack/.golint_failures
View File

@ -170,7 +170,6 @@ pkg/kubelet/metrics
pkg/kubelet/pluginmanager/pluginwatcher pkg/kubelet/pluginmanager/pluginwatcher
pkg/kubelet/pod/testing pkg/kubelet/pod/testing
pkg/kubelet/preemption pkg/kubelet/preemption
pkg/kubelet/prober/testing
pkg/kubelet/qos pkg/kubelet/qos
pkg/kubelet/remote pkg/kubelet/remote
pkg/kubelet/stats pkg/kubelet/stats

24
pkg/kubelet/prober/testing/fake_manager.go
View File

@ -17,19 +17,29 @@ limitations under the License.
package testing package testing
import ( import (
"k8s.io/api/core/v1" v1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types" "k8s.io/apimachinery/pkg/types"
) )
// FakeManager simulates a prober.Manager for testing.
type FakeManager struct{} type FakeManager struct{}
// Unused methods. // Unused methods below.
func (_ FakeManager) AddPod(_ *v1.Pod) {}
func (_ FakeManager) RemovePod(_ *v1.Pod) {}
func (_ FakeManager) CleanupPods(_ []*v1.Pod) {}
func (_ FakeManager) Start() {}
func (_ FakeManager) UpdatePodStatus(_ types.UID, podStatus *v1.PodStatus) { // AddPod simulates adding a Pod.
func (FakeManager) AddPod(_ *v1.Pod) {}
// RemovePod simulates removing a Pod.
func (FakeManager) RemovePod(_ *v1.Pod) {}
// CleanupPods simulates cleaning up Pods.
func (FakeManager) CleanupPods(_ []*v1.Pod) {}
// Start simulates start syncing the probe status
func (FakeManager) Start() {}
// UpdatePodStatus simulates updating the Pod Status.
func (FakeManager) UpdatePodStatus(_ types.UID, podStatus *v1.PodStatus) {
for i := range podStatus.ContainerStatuses { for i := range podStatus.ContainerStatuses {
podStatus.ContainerStatuses[i].Ready = true podStatus.ContainerStatuses[i].Ready = true
} }

7
pkg/kubelet/secret/fake_manager.go
View File

@ -16,9 +16,7 @@ limitations under the License.
package secret package secret
import ( import v1 "k8s.io/api/core/v1"
"k8s.io/api/core/v1"
)
// fakeManager implements Manager interface for testing purposes. // fakeManager implements Manager interface for testing purposes.
// simple operations to apiserver. // simple operations to apiserver.
@ -30,12 +28,15 @@ func NewFakeManager() Manager {
return &fakeManager{} return &fakeManager{}
} }
// GetSecret returns a nil secret for testing
func (s *fakeManager) GetSecret(namespace, name string) (*v1.Secret, error) { func (s *fakeManager) GetSecret(namespace, name string) (*v1.Secret, error) {
return nil, nil return nil, nil
} }
// RegisterPod implements the RegisterPod method for testing purposes.
func (s *fakeManager) RegisterPod(pod *v1.Pod) { func (s *fakeManager) RegisterPod(pod *v1.Pod) {
} }
// UnregisterPod implements the UnregisterPod method for testing purposes.
func (s *fakeManager) UnregisterPod(pod *v1.Pod) { func (s *fakeManager) UnregisterPod(pod *v1.Pod) {
} }

5
pkg/kubelet/secret/secret_manager.go
View File

@ -20,7 +20,7 @@ import (
"fmt" "fmt"
"time" "time"
"k8s.io/api/core/v1" v1 "k8s.io/api/core/v1"
clientset "k8s.io/client-go/kubernetes" clientset "k8s.io/client-go/kubernetes"
podutil "k8s.io/kubernetes/pkg/api/v1/pod" podutil "k8s.io/kubernetes/pkg/api/v1/pod"
corev1 "k8s.io/kubernetes/pkg/apis/core/v1" corev1 "k8s.io/kubernetes/pkg/apis/core/v1"
@ -33,7 +33,8 @@ import (
"k8s.io/apimachinery/pkg/watch" "k8s.io/apimachinery/pkg/watch"
) )
// Manager interface provides methods for Kubelet to manage secrets. // Manager manages Kubernets secrets. This includes retrieving
// secrets or registering/unregistering them via Pods.
type Manager interface { type Manager interface {
// Get secret by secret namespace and name. // Get secret by secret namespace and name.
GetSecret(namespace, name string) (*v1.Secret, error) GetSecret(namespace, name string) (*v1.Secret, error)