diff --git a/hack/.golint_failures b/hack/.golint_failures index 9fba7988f66..f5979993205 100644 --- a/hack/.golint_failures +++ b/hack/.golint_failures @@ -8,7 +8,6 @@ pkg/apis/abac/v1beta1 pkg/apis/admission pkg/apis/admissionregistration/v1 pkg/apis/admissionregistration/v1beta1 -pkg/apis/admissionregistration/validation pkg/apis/apps/v1 pkg/apis/apps/v1beta1 pkg/apis/apps/v1beta2 diff --git a/pkg/apis/admissionregistration/v1/defaults.go b/pkg/apis/admissionregistration/v1/defaults.go index 7a63c5cdf71..217bf224fe8 100644 --- a/pkg/apis/admissionregistration/v1/defaults.go +++ b/pkg/apis/admissionregistration/v1/defaults.go @@ -27,6 +27,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error { return RegisterDefaults(scheme) } +// SetDefaults_ValidatingWebhook sets defaults for webhook validating func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1.ValidatingWebhook) { if obj.FailurePolicy == nil { policy := admissionregistrationv1.Fail @@ -50,6 +51,7 @@ func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1.ValidatingWebhoo } } +// SetDefaults_MutatingWebhook sets defaults for webhook mutating func SetDefaults_MutatingWebhook(obj *admissionregistrationv1.MutatingWebhook) { if obj.FailurePolicy == nil { policy := admissionregistrationv1.Fail @@ -77,6 +79,7 @@ func SetDefaults_MutatingWebhook(obj *admissionregistrationv1.MutatingWebhook) { } } +// SetDefaults_Rule sets defaults for webhook rule func SetDefaults_Rule(obj *admissionregistrationv1.Rule) { if obj.Scope == nil { s := admissionregistrationv1.AllScopes diff --git a/pkg/apis/admissionregistration/v1/register.go b/pkg/apis/admissionregistration/v1/register.go index d84f1a0da5a..32a76d7cb7d 100644 --- a/pkg/apis/admissionregistration/v1/register.go +++ b/pkg/apis/admissionregistration/v1/register.go @@ -21,6 +21,7 @@ import ( "k8s.io/apimachinery/pkg/runtime/schema" ) +// GroupName is the group name used in this package const GroupName = "admissionregistration.k8s.io" // SchemeGroupVersion is group version used to register these objects @@ -33,7 +34,8 @@ func Resource(resource string) schema.GroupResource { var ( localSchemeBuilder = &admissionregistrationv1.SchemeBuilder - AddToScheme = localSchemeBuilder.AddToScheme + // AddToScheme handler to add items to the schema + AddToScheme = localSchemeBuilder.AddToScheme ) func init() { diff --git a/pkg/apis/admissionregistration/v1beta1/defaults.go b/pkg/apis/admissionregistration/v1beta1/defaults.go index 2afa0642b76..f0796fc9b73 100644 --- a/pkg/apis/admissionregistration/v1beta1/defaults.go +++ b/pkg/apis/admissionregistration/v1beta1/defaults.go @@ -27,6 +27,7 @@ func addDefaultingFuncs(scheme *runtime.Scheme) error { return RegisterDefaults(scheme) } +// SetDefaults_ValidatingWebhook sets defaults for webhook validating func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1beta1.ValidatingWebhook) { if obj.FailurePolicy == nil { policy := admissionregistrationv1beta1.Ignore @@ -59,6 +60,7 @@ func SetDefaults_ValidatingWebhook(obj *admissionregistrationv1beta1.ValidatingW } } +// SetDefaults_MutatingWebhook sets defaults for webhook mutating func SetDefaults_MutatingWebhook(obj *admissionregistrationv1beta1.MutatingWebhook) { if obj.FailurePolicy == nil { policy := admissionregistrationv1beta1.Ignore @@ -95,6 +97,7 @@ func SetDefaults_MutatingWebhook(obj *admissionregistrationv1beta1.MutatingWebho } } +// SetDefaults_Rule sets defaults for webhook rule func SetDefaults_Rule(obj *admissionregistrationv1beta1.Rule) { if obj.Scope == nil { s := admissionregistrationv1beta1.AllScopes diff --git a/pkg/apis/admissionregistration/v1beta1/register.go b/pkg/apis/admissionregistration/v1beta1/register.go index ff505a577e1..92d22f9ace3 100644 --- a/pkg/apis/admissionregistration/v1beta1/register.go +++ b/pkg/apis/admissionregistration/v1beta1/register.go @@ -21,6 +21,7 @@ import ( "k8s.io/apimachinery/pkg/runtime/schema" ) +// GroupName is the group name used in this package const GroupName = "admissionregistration.k8s.io" // SchemeGroupVersion is group version used to register these objects @@ -33,7 +34,8 @@ func Resource(resource string) schema.GroupResource { var ( localSchemeBuilder = &admissionregistrationv1beta1.SchemeBuilder - AddToScheme = localSchemeBuilder.AddToScheme + // AddToScheme handler to add items to the schema + AddToScheme = localSchemeBuilder.AddToScheme ) func init() { diff --git a/pkg/apis/admissionregistration/validation/validation.go b/pkg/apis/admissionregistration/validation/validation.go index 01ec17eb438..9f0832cf9d0 100644 --- a/pkg/apis/admissionregistration/validation/validation.go +++ b/pkg/apis/admissionregistration/validation/validation.go @@ -496,6 +496,7 @@ func validatingHasNoSideEffects(webhooks []admissionregistration.ValidatingWebho return true } +// ValidateValidatingWebhookConfigurationUpdate validates update of validating webhook configuration func ValidateValidatingWebhookConfigurationUpdate(newC, oldC *admissionregistration.ValidatingWebhookConfiguration, requestGV schema.GroupVersion) field.ErrorList { return validateValidatingWebhookConfiguration(newC, validationOptions{ requireNoSideEffects: requireNoSideEffects(requestGV) && validatingHasNoSideEffects(oldC.Webhooks), @@ -504,6 +505,7 @@ func ValidateValidatingWebhookConfigurationUpdate(newC, oldC *admissionregistrat }) } +// ValidateMutatingWebhookConfigurationUpdate validates update of mutating webhook configuration func ValidateMutatingWebhookConfigurationUpdate(newC, oldC *admissionregistration.MutatingWebhookConfiguration, requestGV schema.GroupVersion) field.ErrorList { return validateMutatingWebhookConfiguration(newC, validationOptions{ requireNoSideEffects: requireNoSideEffects(requestGV) && mutatingHasNoSideEffects(oldC.Webhooks),