From cc999f69e772071d0c13cb4d0a5884bbe3bb39f3 Mon Sep 17 00:00:00 2001 From: kerthcet Date: Sat, 20 Nov 2021 15:12:09 +0800 Subject: [PATCH] add several testcases to cover PriorityClass admission veeifications Signed-off-by: kerthcet --- .../pkg/admission/priority/admission_test.go | 54 +++++++++++++++++-- 1 file changed, 50 insertions(+), 4 deletions(-) diff --git a/plugin/pkg/admission/priority/admission_test.go b/plugin/pkg/admission/priority/admission_test.go index 628de429004..d603d335488 100644 --- a/plugin/pkg/admission/priority/admission_test.go +++ b/plugin/pkg/admission/priority/admission_test.go @@ -143,29 +143,75 @@ func TestPriorityClassAdmission(t *testing.T) { existingClasses []*scheduling.PriorityClass newClass *scheduling.PriorityClass userInfo user.Info + operation admission.Operation expectError bool }{ { - "one default class", + "create operator with default class", []*scheduling.PriorityClass{}, defaultClass1, nil, + admission.Create, false, }, { - "more than one default classes", + "create operator with one existing default class", []*scheduling.PriorityClass{defaultClass1}, defaultClass2, nil, + admission.Create, true, }, { - "system name and value are allowed by admission controller", + "create operator with system name and value allowed by admission controller", []*scheduling.PriorityClass{}, systemClass, &user.DefaultInfo{ Name: user.APIServerUser, }, + admission.Create, + false, + }, + { + "update operator with default class", + []*scheduling.PriorityClass{}, + defaultClass1, + nil, + admission.Update, + false, + }, + { + "update operator with one existing default class", + []*scheduling.PriorityClass{defaultClass1}, + defaultClass2, + nil, + admission.Update, + true, + }, + { + "update operator with system name and value allowed by admission controller", + []*scheduling.PriorityClass{}, + systemClass, + &user.DefaultInfo{ + Name: user.APIServerUser, + }, + admission.Update, + false, + }, + { + "update operator with different default classes", + []*scheduling.PriorityClass{defaultClass1}, + defaultClass2, + nil, + admission.Update, + true, + }, + { + "delete operation with default class", + []*scheduling.PriorityClass{}, + defaultClass1, + nil, + admission.Delete, false, }, } @@ -187,7 +233,7 @@ func TestPriorityClassAdmission(t *testing.T) { "", scheduling.Resource("priorityclasses").WithVersion("version"), "", - admission.Create, + test.operation, &metav1.CreateOptions{}, false, test.userInfo,