github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-19 09:52:49 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #115808 from dgrisonnet/revert-115455

Browse Source 
Revert "restclient: rename "method" label to "verb""
This commit is contained in:
Kubernetes Prow Robot 2023-02-15 13:52:19 -08:00 committed by GitHub
commit ccaa730805
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics.go
View File

@ -77,9 +77,9 @@ var (
&k8smetrics.CounterOpts{
Name: "rest_client_requests_total",
StabilityLevel: k8smetrics.ALPHA,
Help: "Number of HTTP requests, partitioned by status code, verb, and host.",
Help: "Number of HTTP requests, partitioned by status code, method, and host.",
},
[]string{"code", "verb", "host"},
[]string{"code", "method", "host"},
)
requestRetry = k8smetrics.NewCounterVec(

4
staging/src/k8s.io/component-base/metrics/prometheus/restclient/metrics_test.go
View File

@ -42,9 +42,9 @@ func TestClientGOMetrics(t *testing.T) {
metrics.RequestResult.Increment(context.TODO(), "200", "POST", "www.foo.com")
},
want: `
# HELP rest_client_requests_total [ALPHA] Number of HTTP requests, partitioned by status code, verb, and host.
# HELP rest_client_requests_total [ALPHA] Number of HTTP requests, partitioned by status code, method, and host.
# TYPE rest_client_requests_total counter
rest_client_requests_total{code="200",host="www.foo.com",verb="POST"} 1
rest_client_requests_total{code="200",host="www.foo.com",method="POST"} 1
`,
},
{