From ccbdf041a2f73318fcebce9e3fe5818d152b7732 Mon Sep 17 00:00:00 2001 From: Jordan Liggitt Date: Wed, 18 Aug 2021 11:30:34 -0400 Subject: [PATCH] Fix slice type comparison bug --- plugin/pkg/admission/serviceaccount/admission_test.go | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/plugin/pkg/admission/serviceaccount/admission_test.go b/plugin/pkg/admission/serviceaccount/admission_test.go index 0ef21a935ee..fb463a08f6f 100644 --- a/plugin/pkg/admission/serviceaccount/admission_test.go +++ b/plugin/pkg/admission/serviceaccount/admission_test.go @@ -747,6 +747,11 @@ func TestAddImagePullSecrets(t *testing.T) { {Name: "bar"}, }, } + originalSA := sa.DeepCopy() + expected := []api.LocalObjectReference{ + {Name: "foo"}, + {Name: "bar"}, + } // Add the default service account for the ns with a secret reference into the cache informerFactory.Core().V1().ServiceAccounts().Informer().GetStore().Add(sa) @@ -757,10 +762,10 @@ func TestAddImagePullSecrets(t *testing.T) { t.Errorf("Unexpected error: %v", err) } - assert.EqualValues(t, sa.ImagePullSecrets, pod.Spec.ImagePullSecrets, "expected %v, got %v", sa.ImagePullSecrets, pod.Spec.ImagePullSecrets) + assert.EqualValues(t, expected, pod.Spec.ImagePullSecrets, "expected %v, got %v", expected, pod.Spec.ImagePullSecrets) pod.Spec.ImagePullSecrets[1] = api.LocalObjectReference{Name: "baz"} - if reflect.DeepEqual(sa.ImagePullSecrets, pod.Spec.ImagePullSecrets) { + if !reflect.DeepEqual(originalSA, sa) { t.Errorf("accidentally mutated the ServiceAccount.ImagePullSecrets: %v", sa.ImagePullSecrets) } }