From cccb66bfbc24c32d80a86716b90a98463d4facba Mon Sep 17 00:00:00 2001 From: Francesco Romani Date: Wed, 15 Oct 2025 12:16:32 +0200 Subject: [PATCH] test: topologymanager: handle panic in test unexpected success should cause a test failure, not a panic Signed-off-by: Francesco Romani --- pkg/kubelet/cm/topologymanager/policy_options_test.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/pkg/kubelet/cm/topologymanager/policy_options_test.go b/pkg/kubelet/cm/topologymanager/policy_options_test.go index 8852a3a172c..80b5cfcdb9b 100644 --- a/pkg/kubelet/cm/topologymanager/policy_options_test.go +++ b/pkg/kubelet/cm/topologymanager/policy_options_test.go @@ -154,7 +154,9 @@ func TestNewTopologyManagerOptions(t *testing.T) { } opts, err := NewPolicyOptions(logger, tcase.policyOptions) if tcase.expectedErr != nil { - if !strings.Contains(err.Error(), tcase.expectedErr.Error()) { + if err == nil { + t.Errorf("expected error %v, got no error", tcase.expectedErr) + } else if !strings.Contains(err.Error(), tcase.expectedErr.Error()) { t.Errorf("Unexpected error message. Have: %s, wants %s", err.Error(), tcase.expectedErr.Error()) } return