github/kubernetes
1
0
Fork 0
mirror of https://github.com/k3s-io/kubernetes.git synced 2025-07-28 05:57:25 +00:00
Code Issues Projects Releases Wiki Activity

Merge pull request #62753 from Random-Liu/fix-extra-log

Browse Source 
Automatic merge from submit-queue (batch tested with PRs 62568, 62220, 62743, 62751, 62753). If you want to cherry-pick this change to another branch, please follow the instructions <a href="https://github.com/kubernetes/community/blob/master/contributors/devel/cherry-picks.md">here</a>.

Fix extra-log flag for node e2e.

Similar with https://github.com/kubernetes/kubernetes/pull/62670.

Without this, test-infra can't collect extra logs, such as contianerd log.

Signed-off-by: Lantao Liu <lantaol@google.com>

**Release note**:

```release-note
none
```
This commit is contained in:
Kubernetes Submit Queue 2018-04-17 20:52:21 -07:00 committed by GitHub
commit cce67ed8e7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 0 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
test/e2e_node/services/logs.go
View File

@ -44,12 +44,6 @@ func (l *logFiles) String() string {
// Set function of flag.Value // Set function of flag.Value
func (l *logFiles) Set(value string) error { func (l *logFiles) Set(value string) error {
// Someone else is calling flag.Parse after the flags are parsed in the
// test framework. Use this to avoid the flag being parsed twice.
// TODO(random-liu): Figure out who is parsing the flags.
if flag.Parsed() {
return nil
}
var log LogFileData var log LogFileData
if err := json.Unmarshal([]byte(value), &log); err != nil { if err := json.Unmarshal([]byte(value), &log); err != nil {
return err return err