From cd0b46874a6b9005187cecb55e885177d1294615 Mon Sep 17 00:00:00 2001 From: "Dr. Stefan Schimanski" Date: Fri, 24 May 2019 11:06:45 +0200 Subject: [PATCH] apiextensions: add storage race TODO in CRD conversion e2e test --- test/e2e/apimachinery/crd_conversion_webhook.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/test/e2e/apimachinery/crd_conversion_webhook.go b/test/e2e/apimachinery/crd_conversion_webhook.go index 485b19b0023..07f2d3dbc35 100644 --- a/test/e2e/apimachinery/crd_conversion_webhook.go +++ b/test/e2e/apimachinery/crd_conversion_webhook.go @@ -40,6 +40,7 @@ import ( "github.com/onsi/ginkgo" "github.com/onsi/gomega" + // ensure libs have a chance to initialize _ "github.com/stretchr/testify/assert" ) @@ -386,6 +387,8 @@ func testCRListConversion(f *framework.Framework, testCrd *crd.TestCrd) { // After changing a CRD, the resources for versions will be re-created that can be result in // cancelled connection (e.g. "grpc connection closed" or "context canceled"). // Just retrying fixes that. + // + // TODO: we have to wait for the storage version to become effective. Storage version changes are not instant. for i := 0; i < 5; i++ { _, err = customResourceClients["v1"].Create(crInstance, metav1.CreateOptions{}) if err == nil {